git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 6/6] fixup! reftable: rest of library

From
Jeff King <peff@peff.net>
Date
Dec 2, 2020, 01:50 UTC
Message-ID
<X8by+j24ccvt0F04@coredump.intra.peff.net>
In-Reply-To
<nycvar.QRO.7.76.6.2012011519340.54@tvgsbejvaqbjf.bet>
On Tue, Dec 01, 2020 at 03:24:01PM +0100, Johannes Schindelin wrote:
> > I don't see it being invoked anywhere,
> 
> It is invoked in `t/t0032-reftable-unittest.sh`:
> https://github.com/dscho/git/blob/reftable-on-windows/t/t0032-reftable-unittest.sh
Ah, thank you. I was looking at what Junio has queued in hn/reftable.
Show 5 quoted lines
> > but presumably if we were to add support to our test suite, we'd have a
> > script which invokes it within a scratch directory.
> 
> I agree that it would make most sense for t0032 to prefix the call to
> `test-tool` with `TMPDIR=$PWD`.
Yep, that would be fine.

I'm not sure if the long-term goal is to have this opaque unit-test program or not. If it is, I was likewise going to suggest that its ad-hoc output be replaced with TAP. But it looks like on your branch that "test-tool reftable" does not produce output at all. So I may be a bit behind on what the current state and forward plans are...

-Peff
Previous: Johannes SchindelinNext: Han-Wen Nienhuys
Message 11 of 22 in “Minimal patches to let reftable pass the CI builds”
  1. 0/6 Minimal patches to let reftable pass the CI buildsJohannes Schindelin via GitGitGadget, Nov 28, 2020
  2. 1/6 fixup! reftable: rest of libraryJohannes Schindelin via GitGitGadget, Nov 28, 2020
  3. Han-Wen NienhuysDec 1, 2020
  4. Johannes SchindelinDec 2, 2020
  5. Reftable locking on Windows (Re: [PATCH 1/6] fixup! reftable: rest of library)Han-Wen Nienhuys, Dec 2, 2020
  6. Ævar Arnfjörð BjarmasonDec 3, 2020
  7. Han-Wen NienhuysDec 3, 2020
  8. 6/6 fixup! reftable: rest of libraryJohannes Schindelin via GitGitGadget, Nov 28, 2020
  9. Jeff KingDec 1, 2020
  10. Johannes SchindelinDec 1, 2020
  11. Jeff KingDec 2, 2020
  12. Han-Wen NienhuysDec 2, 2020
  13. Jeff KingDec 2, 2020
  14. 4/6 fixup! reftable: rest of libraryJohannes Schindelin via GitGitGadget, Nov 28, 2020
  15. 2/6 fixup! reftable: utility functionsJohannes Schindelin via GitGitGadget, Nov 28, 2020
  16. 3/6 fixup! reftable: rest of libraryJohannes Schindelin via GitGitGadget, Nov 28, 2020
  17. Jeff KingDec 1, 2020
  18. Han-Wen NienhuysDec 1, 2020
  19. Jeff KingDec 1, 2020
  20. 5/6 fixup! reftable: rest of libraryJohannes Schindelin via GitGitGadget, Nov 28, 2020
  21. Han-Wen NienhuysNov 30, 2020
  22. Johannes SchindelinDec 1, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.