Re: [PATCH v4 07/15] bugreport: add curl version
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Dec 17, 2019, 18:47 UTC
- Message-ID
- <nycvar.QRO.7.76.6.1912171946260.46@tvgsbejvaqbjf.bet>
- In-Reply-To
- <20191213004312.169753-8-emilyshaffer@google.com>
Hi Emily,
On Thu, 12 Dec 2019, Emily Shaffer wrote:
Show 15 quoted lines
> diff --git a/http-fetch.c b/http-fetch.c > index a32ac118d9..31844812a1 100644 > --- a/http-fetch.c > +++ b/http-fetch.c > @@ -3,9 +3,18 @@ > #include "exec-cmd.h" > #include "http.h" > #include "walker.h" > +#include "version.h" > > static const char http_fetch_usage[] = "git http-fetch " > -"[-c] [-t] [-a] [-v] [--recover] [-w ref] [--stdin] commit-id url"; > +"[-c] [-t] [-a] [-v] [-V] [--recover] [-w ref] [--stdin] commit-id url"; > + > +void NORETURN version_info()
Pretty much all the builds in https://dev.azure.com/gitgitgadget/git/_build/results?buildId=23830&view=logs&jobId=253e5128-1058-5bd4-fdf1-9b556d3207f8&j=fd490c07-0b22-5182-fac9-6d67fe1e939b&t=ce91d5d6-0c55-50f5-8ab9-6695c03ab102 fail because this function definition needs `(void)` instead of `()`.
Ciao, Dscho
Show 23 quoted lines
> +{
> + printf("git-http-fetch version: %s\n", git_version_string);
> + printf("built from commit: %s\n", git_built_from_commit_string);
> + printf("curl version: %s\n", curl_version());
> + exit(0);
> +}
>
> int cmd_main(int argc, const char **argv)
> {
> @@ -26,6 +35,8 @@ int cmd_main(int argc, const char **argv)
> } else if (argv[arg][1] == 'a') {
> } else if (argv[arg][1] == 'v') {
> get_verbosely = 1;
> + } else if (argv[arg][1] == 'V') {
> + version_info();
> } else if (argv[arg][1] == 'w') {
> write_ref = &argv[arg + 1];
> arg++;
> --
> 2.24.1.735.g03f4e72817-goog
>
>
>