Re: [PATCH v5 04/15] help: add shell-path to --build-options
- From
- Martin Ågren <martin.agren@gmail.com>
- Date
- Jan 30, 2020, 22:21 UTC
- Message-ID
- <CAN0heSqKXAxOGBayEx+29EKFKqBWhrCymUF5X++OVj78=zhdmw@mail.gmail.com>
- In-Reply-To
- <20200124033436.81097-5-emilyshaffer@google.com>
On Fri, 24 Jan 2020 at 04:40, <emilyshaffer@google.com> wrote:
Show 6 quoted lines
> It may be useful to know which shell Git was built to try to point to, > in the event that shell-based Git commands are failing. $SHELL_PATH is > set during the build and used to launch the manpage viewer, as well as > by git-compat-util.h, and it's used during tests. 'git version > --build-options' is encouraged for use in bug reports, so it makes sense > to include this information there.
Hmm, similar nit as for patch 02/15: This could go in as, e.g., 02/15 and your 01/15 would be 03/15: This patch would be useful even without `git bugreport`.
Martin