Re: [PATCH v7 06/15] bugreport: add compiler info

From: Emily Shaffer <emilyshaffer@google.com>
Date: Feb 20, 2020, 23:33 UTC
Message-ID: <20200220233323.GI2447@google.com>
In-Reply-To: <nycvar.QRO.7.76.6.2002202306390.46@tvgsbejvaqbjf.bet>

On Thu, Feb 20, 2020 at 11:33:05PM +0100, Johannes Schindelin wrote:

Show 30 quoted lines

> Hi Emily,
> 
> On Wed, 19 Feb 2020, Emily Shaffer wrote:
> 
> >   #ifdef __GLIBC__
> >   #include <gnu/libc-version.h>
> >   #endif
> >
> >   static inline void get_compiler_info(struct strbuf *info)
> >   {
> >   	#ifdef __GLIBC__
> > 	strbuf_addf(info, "glibc: %s\n", gnu_get_libc_version());
> > 	#endif
> >
> > 	#ifdef __GNUC__
> > 	strbuf_addf(info, "gnuc: %d.%d\n", __GNUC__, __GNUC_MINOR__);
> > 	#endif
> >
> > 	#ifdef _MSC_VER
> > 	strbuf_addf(info, "msc runtime: %s\n", some_msc_info());
> 
> You could do it this way right away:
> 
> 	strbuf_addf(info, "MSVC version: %d.%d\n",
> 		    _MSC_VER / 100, _MSC_VER % 100);
> 
> Note: this is _not_ the MSVC _runtime_ version, but really the compiler
> version.
> 
> You could also use _MSC_FULL_VER, which is a bit more complete.

Sorry, but I'm not comfortable sending code I can't check for myself (and already muscle-memoried into my format-patch/send-email workflow). If you send a scissors I can roll it into the series with your SOB.

 - Emily