[PATCH v5 06/15] bugreport: add compiler info
- From
emilyshaffer@google.com <emilyshaffer@google.com>
- Date
- Jan 24, 2020, 03:34 UTC
- Message-ID
- <20200124033436.81097-7-emilyshaffer@google.com>
- In-Reply-To
- <20200124033436.81097-1-emilyshaffer@google.com>
From: Emily Shaffer <emilyshaffer@google.com>
To help pinpoint the source of a regression, it is useful to know some info about the compiler which the user's Git client was built with. By adding a generic get_compiler_info() in 'compat/' we can choose which relevant information to share per compiler; to get started, let's demonstrate the version of glibc if the user built with 'gcc'.
Signed-off-by: Emily Shaffer <emilyshaffer@google.com> --- bugreport.c | 5 +++++ compat/compiler.h | 24 ++++++++++++++++++++++++ 2 files changed, 29 insertions(+) create mode 100644 compat/compiler.h
diff --git a/bugreport.c b/bugreport.c index 720c91e1bd..818ccb385c 100644 --- a/bugreport.c +++ b/bugreport.c @@ -4,6 +4,7 @@ #include "strbuf.h" #include "time.h" #include "help.h" +#include "compat/compiler.h" static void get_system_info(struct strbuf *sys_info) { @@ -26,6 +27,10 @@ static void get_system_info(struct strbuf *sys_info) uname_info.release, uname_info.version, uname_info.machine); + + strbuf_addstr(sys_info, "compiler info: "); + get_compiler_info(sys_info); + strbuf_complete_line(sys_info); } static const char * const bugreport_usage[] = { diff --git a/compat/compiler.h b/compat/compiler.h new file mode 100644 index 0000000000..bda5098e1b --- /dev/null +++ b/compat/compiler.h @@ -0,0 +1,24 @@ +#ifndef COMPILER_H +#define COMPILER_H + +#include "git-compat-util.h" +#include "strbuf.h" + +#ifdef __GLIBC__ +#include <gnu/libc-version.h> + +static inline void get_compiler_info(struct strbuf *info) +{ + strbuf_addf(info, "glibc: %s", gnu_get_libc_version()); +} + +#else + +static inline void get_compiler_info(struct strbuf *info) +{ + strbuf_addstr(info, "get_compiler_info() not implemented"); +} + +#endif + +#endif /* COMPILER_H */
-- 2.25.0.341.g760bfbb309-goog