git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Making GitGitGadget's list -> PR comment mirroring bidirectional, was Re: [PATCH] Feature: custom guitool commands can now have custom keyboard shortcuts

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Nov 19, 2019, 22:09 UTC
Message-ID
<nycvar.QRO.7.76.6.1911192305410.15956@tvgsbejvaqbjf.bet>
In-Reply-To
<20191006210647.wfjr7lhw5fxs4bin@yadavpratyush.com>
Hi Pratyush,
On Mon, 7 Oct 2019, Pratyush Yadav wrote:
Show 43 quoted lines
> On 06/10/19 10:27PM, Johannes Schindelin wrote:
> > Hi Pratyush,
> >
> > On Mon, 7 Oct 2019, Pratyush Yadav wrote:
> >
> > > Anyway, GitGitGadget solves a large part of the problem. It
> > > eliminates the need for using git-send-email, and it even shows you
> > > the replies received on the list. I honestly think it is a great
> > > tool, and it gives people a very good alternative to using
> > > git-send-email.
> >
> > GitGitGadget is just a workaround. Not even complete. Can't be
> > complete, really. Because problems. It has much of the same problems
> > of `git send-email`: it's a one-way conversation. Code is not
> > discussed in the right context (which would be a worktree with the
> > correct commit checked out). The transfer is lossy (email is designed
> > for human-readable messages, not for transferring machine-readable
> > serialized objects). Matching original commits and/or branches to the
> > ones on the other side is tedious. Any interaction requires switching
> > between many tools. Etc
> >
> > > One feature that would make it complete would be the ability to
> > > reply to review comments.
> >
> > And how would that work, exactly? How to determine *which* email to
> > respond to? *Which* person to reply to? *What* to quote?
>
> GGG already shows replies to the patches as a comment. On GitHub you can
> "Quote reply" a comment, which quotes the entire comment just like your
> MUA would. The option can be found by clicking the 3 dots on the top
> right of a comment.
>
> Then you can write your reply there, and the last line would be
> '/reply', which would make GGG send that email as a reply. You would
> need to strip the first line from the reply because GGG starts the reply
> with something like:
>
>   > [On the Git mailing list](https://public-inbox.org/git/xmqq7e5l9zb1.fsf@gitster-ct.c.googlers.com), Junio C Hamano wrote ([reply to this](https://github.com/gitgitgadget/gitgitgadget/wiki/ReplyToThis)):
>
> GGG also adds 3 backticks before and after the reply content, so those
> would need to be removed too.
>
> Does this sound like a sane solution?

Here are two real life examples where an unsuspecting GitGitGadget user expected GitGitGadget to mirror replies _to_ the Git mailing list:

https://github.com/gitgitgadget/git/pull/451#issuecomment-555044068 and https://github.com/gitgitgadget/git/pull/451#issuecomment-555077933

Neither of them include the line with the link.
Just to throw a bit of real life into the discussion...

Ciao, Dscho

Previous: Alban GruinNext: Pratyush Yadav
Message 18 of 27 in “Feature: custom guitool commands can now have custom keyboard shortcuts”
  1. Feature: custom guitool commands can now have custom keyboard shortcutsHarish K, Mar 29, 2016
  2. David AguilarMar 31, 2016
  3. harish kApr 1, 2016
  4. harish kOct 3, 2019
  5. Pratyush YadavOct 3, 2019
  6. Johannes SchindelinOct 4, 2019
  7. Pratyush YadavOct 4, 2019
  8. Harish KarumuthilOct 5, 2019
  9. Pratyush YadavOct 5, 2019
  10. Johannes SchindelinOct 6, 2019
  11. Pratyush YadavOct 6, 2019
  12. Philip OakleyOct 6, 2019
  13. Johannes SchindelinOct 6, 2019
  14. Pratyush YadavOct 6, 2019
  15. GitGUIGadget, was Re: [PATCH] Feature: custom guitool commands can now have custom keyboard shortcutsJohannes Schindelin, Oct 7, 2019
  16. Birger Skogeng PedersenOct 7, 2019
  17. Alban GruinOct 7, 2019
  18. Making GitGitGadget's list -> PR comment mirroring bidirectional, was Re: [PATCH] Feature: custom guitool commands can now have custom keyboard shortcutsJohannes Schindelin, Nov 19, 2019
  19. Pratyush YadavNov 20, 2019
  20. Philip OakleyOct 6, 2019
  21. Harish KarumuthilOct 7, 2019
  22. Johannes SchindelinOct 7, 2019
  23. Harish KarumuthilOct 8, 2019
  24. Johannes SchindelinOct 9, 2019
  25. Pratyush YadavOct 13, 2019
  26. Harish KarumuthilOct 7, 2019
  27. Pratyush YadavOct 13, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.