git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Feature: custom guitool commands can now have custom keyboard shortcuts

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Oct 6, 2019, 09:49 UTC
Message-ID
<nycvar.QRO.7.76.6.1910061054470.46@tvgsbejvaqbjf.bet>
In-Reply-To
<20191005210127.uinrgazj5ezyqftj@yadavpratyush.com>
Hi Pratyush,
On Sun, 6 Oct 2019, Pratyush Yadav wrote:
Show 11 quoted lines
> On 06/10/19 01:46AM, Harish Karumuthil wrote:
> >
> > From https://www.kernel.org/doc/html/v4.10/process/email-clients.html, I
> > understood that, my current email client ( that is gmail web ) is not good
> > for submitting patches. So I was tying to setup a mail client which is
> > compatible with `git send-mail`. But I was not able to get a satisfactory
> > result in that.
>
> You don't need to "set up" an email client with git-send-email.
> git-send-email is an email client itself. Well, one which can only send
> emails.
It also cannot reply to mails on the mailing list.
It cannot even notify you when anybody replied to your patch.

Two rather problematic aspects when it comes to patch contributions: how are you supposed to work with the reviewers when you lack all the tools to _interact_ with them? All `git send-email` provides is a "fire and forget" way to send patches, i.e. it encourages a monologue, when you want to start a dialogue instead.

Show 18 quoted lines
> So what you should do is run `git format-patch -o feature master..HEAD`,
> assuming your feature branch is checked out. This will give you a set of
> '.patch' files depending on how many commits you made in your branch in
> the folder feature/. Then, you can run
>
>   git send-email --to='Pratyush Yadav <me@yadavpratyush.com>' --cc='<git@vger.kernel.org>' feature/*.patch
>
> This will send all your patch files via email to me with the git list in
> Cc. You can add multiple '--to' and '--cc' options to send it to
> multiple people.
>
> Try sending the patches to yourself to experiment around with it.
>
> A pretty good tutorial to configuring and using git-send-email can be
> found at [0]. And of course, read the man page.
>
> These instructions are for Linux, but you can probably do something
> similar in Windows too (if you're using Windows that is).
Last I checked, `git send-email` worked in Git for Windows.

But of course, it does not only not address the problem it tries to solve fully (to provide a way to interact with a mailing list when submitting patches for review), not even close, to add insult to injury, it now adds an additional burden to contributors (who might already have struggled to learn themselves enough Tcl/Tk to fix the problem) to configure `git send-email` correctly.

Show 6 quoted lines
> > For now, I followed the instruction of Johannes Schindelin and submitted a
> > pull request . Please see https://github.com/gitgitgadget/git/pull/376
>
> You haven't sent '/submit' over there, so those emails aren't in the
> list (and my inbox) yet. You need to comment with '/submit' (without the
> quotes) to tell GitGitGadget to send your PR as email.

They probably did not hit `/submit` because the initial hurdle is to be `/allow`ed (a very, very simplistic attempt at trying to prevent spamming the mailing list by jokesters, of which there are unfortunately quite a number).

This `/allow` command, BTW, can be issued by anybody who has been `/allow`ed before, it does not always have to be me.

FWIW you should probably be in that list of `/allow`ed people so that you can `/allow` new contributors to use GitGitGadget, too.

Show 14 quoted lines
> [...]
>
> > Since #1 is a serious issue, I tried to find out the function which does the
> > keycode validation, but I haven't succeded till now. ( I found the C function
> > name  which is "TkStringToKeysym" from TK source, but I couldn't find its TCL
> > binding ). It will be helpful if any one can help me on this.
>
> I really think you shouldn't dive around in the C parts of Tcl. I
> haven't looked too deeply into this, but you can probably wrap your bind
> calls in `catch` [2] and handle errors from there. Again, I haven't
> tried actually doing this, so you do need to check first.
>
> You can find examples of how to use `catch` in our codebase. Just search
> for it.

FWIW in addition to the `catch` method, I would also recommend looking into a minimal (not even necessarily complete) way to translate the Qt way to specify the keyboard shortcuts (as used by `git-cola`) to Tk ones.

As indicated in https://github.com/git/git/pull/220#issuecomment-536045075, the Qt style `CTRL+,` should be translated to `Control-comma`, for example. In particular, keystrokes specified in the format indicated at https://doc.qt.io/archives/qt-4.8/qkeysequence.html#QKeySequence-2 to the format indicated at https://www.tcl.tk/man/tcl8.4/TkCmd/keysyms.htm.

However, it might not even need to put in _such_ a lot of work: in my tests, `Control-,` worked just as well as `Control-comma`. To test this for yourself, use this snippet (that is slightly modified from the example at the bottom of https://www.tcl.tk/man/tcl/TkCmd/bind.htm so that it reacts _only_ to Control+comma instead of all keys):

-- snip --
set keysym "Press any key"
pack [label .l -textvariable keysym -padx 2m -pady 1m]
#bind . <Key> {
bind . <Control-,> {
    set keysym "You pressed %K"
}
-- snap --

So I could imagine that something like this could serve as an initial draft for a function that you can turn into a "good enough" version:

-- snip --
proc QKeySequence2keysym {keystroke} {
	regsub -all {(?i)Ctrl\+} $keystroke "Control-" keystroke
	regsub -all {(?i)Alt\+} $keystroke "Alt-" keystroke
	regsub -all {(?i)Shift\+} $keystroke "Shift-" keystroke
	return $keystroke
}
-- snap --

That way, you don't have to introduce settings separate from `git-cola`'s, and you can reuse the short-and-sweet variable name.

Ciao, Johannes

Previous: Pratyush YadavNext: Pratyush Yadav
Message 10 of 27 in “Feature: custom guitool commands can now have custom keyboard shortcuts”
  1. Feature: custom guitool commands can now have custom keyboard shortcutsHarish K, Mar 29, 2016
  2. David AguilarMar 31, 2016
  3. harish kApr 1, 2016
  4. harish kOct 3, 2019
  5. Pratyush YadavOct 3, 2019
  6. Johannes SchindelinOct 4, 2019
  7. Pratyush YadavOct 4, 2019
  8. Harish KarumuthilOct 5, 2019
  9. Pratyush YadavOct 5, 2019
  10. Johannes SchindelinOct 6, 2019
  11. Pratyush YadavOct 6, 2019
  12. Philip OakleyOct 6, 2019
  13. Johannes SchindelinOct 6, 2019
  14. Pratyush YadavOct 6, 2019
  15. GitGUIGadget, was Re: [PATCH] Feature: custom guitool commands can now have custom keyboard shortcutsJohannes Schindelin, Oct 7, 2019
  16. Birger Skogeng PedersenOct 7, 2019
  17. Alban GruinOct 7, 2019
  18. Making GitGitGadget's list -> PR comment mirroring bidirectional, was Re: [PATCH] Feature: custom guitool commands can now have custom keyboard shortcutsJohannes Schindelin, Nov 19, 2019
  19. Pratyush YadavNov 20, 2019
  20. Philip OakleyOct 6, 2019
  21. Harish KarumuthilOct 7, 2019
  22. Johannes SchindelinOct 7, 2019
  23. Harish KarumuthilOct 8, 2019
  24. Johannes SchindelinOct 9, 2019
  25. Pratyush YadavOct 13, 2019
  26. Harish KarumuthilOct 7, 2019
  27. Pratyush YadavOct 13, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.