Re: [PATCH] Feature: custom guitool commands can now have custom keyboard shortcuts

From: Philip Oakley <philipoakley@iee.email>
Date: Oct 6, 2019, 19:37 UTC
Message-ID: <293e0738-85dd-14eb-20b9-a837aa88c0cc@iee.email>
In-Reply-To: <20191006183948.5n23sdy2l4uwl6kb@yadavpratyush.com>

On 06/10/2019 19:39, Pratyush Yadav wrote:

Show 8 quoted lines

>> That way, you don't have to introduce settings separate from
>> `git-cola`'s, and you can reuse the short-and-sweet variable name.
> I think a more important question is whether we_really_  need to have
> compatibility with git-cola. Most of our shortcuts don't match with
> them, so is it really worth the effort to try to keep compatibility?
>
> I'm not against something like this, but just want to be sure we
> evaluate whether the effort is worth it.

I just wondered if the custom list would/could be split between a "Common-shortcuts" list, and "GUI-local" list (and hence, elsewhere, a "Cola-local" list)

I don't use Cola at all, so this is just a bikeshed comment...

-- 
Philip