Re: [PATCH] Feature: custom guitool commands can now have custom keyboard shortcuts
- From
Harish Karumuthil <harish2704@gmail.com>
- Date
- Oct 8, 2019, 19:31 UTC
- Message-ID
- <f751705949a7fd23c77cbbf839c081b95b12394b.camel@gmail.com>
- In-Reply-To
- <nycvar.QRO.7.76.6.1910071159530.46@tvgsbejvaqbjf.bet>
Hi all, there is an update:
I added necessary error catching code so that, script will not crash if the keybinding code is worng. Instead of crashing it will print error message. The final patch will look something like this.
--- lib/tools.tcl | 24 ++++++++++++++++++++---- 1 file changed, 20 insertions(+), 4 deletions(-)
diff --git a/lib/tools.tcl b/lib/tools.tcl index 413f1a1700..3135e19131 100644 --- a/lib/tools.tcl +++ b/lib/tools.tcl @@ -38,7 +38,7 @@ proc tools_create_item {parent args} { } proc tools_populate_one {fullname} { - global tools_menubar tools_menutbl tools_id + global tools_menubar tools_menutbl tools_id repo_config if {![info exists tools_id]} { set tools_id 0 @@ -61,9 +61,25 @@ proc tools_populate_one {fullname} { } } - tools_create_item $parent command \ - -label [lindex $names end] \ - -command [list tools_exec $fullname] + set accel_key_bound 0 + if {[info exists repo_config(guitool.$fullname.gitgui-shortcut)]} { + set accel_key $repo_config(guitool.$fullname.gitgui-shortcut) + if { [ catch { bind . <$accel_key> [list tools_exec $fullname] } msg ] } { + puts stderr "Failed to bind keyboard shortcut '$accel_key' for custom tool '$fullname'. Error: $msg" + } else { + tools_create_item $parent command \ + -label [lindex $names end] \ + -command [list tools_exec $fullname] \ + -accelerator $accel_key + set accel_key_bound true + } + } + + if { ! $accel_key_bound } { + tools_create_item $parent command \ + -label [lindex $names end] \ + -command [list tools_exec $fullname] + } } proc tools_exec {fullname} { --- @Johannes Schindelin: In short, from your previous message I understand point. 1. shortcut codes like "<Control-,>" will only in Windows platform. It may not work in Linux / Mac. 2. We need do translate shortcut codes somehow ( using one-to-one maping ). If this is correct, do you have any example on how to do one-to-one maping of a list of string on TCL ?