Re: [RFC PATCH v3 2/3] grep: make PCRE2 aware of custom allocator

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Aug 8, 2019, 20:18 UTC
Message-ID: <nycvar.QRO.7.76.6.1908082213400.46@tvgsbejvaqbjf.bet>
In-Reply-To: <7f42007f-911b-c570-17f6-1c6af0429586@web.de>

Hi René,

On Thu, 8 Aug 2019, René Scharfe wrote:

Show 11 quoted lines

> Importing the latest version of nedmalloc might make sense in general.
> The last commit in git://github.com/ned14/nedmalloc.git was done five
> years ago; is it finished?  A diffstat with -b looks like this:
>
>  malloc.c.h  | 1193 ++++++++++++++++++++++++++++-------------
>  nedmalloc.c | 1720 +++++++++++++++++++++++++++++++++++++++++++++++++++++-------
>  nedmalloc.h | 1580 ++++++++++++++++++++++++++++++++++++++++++++++++++++---
>  3 files changed, 3840 insertions(+), 653 deletions(-)
>
> Any nedmalloc fans interested in bringing the goodies hidden in there
> to Git (presumably while retaining our local fixes)?

I had looked into this already over two years ago, and had to stop after investigating a performance regression for two weeks and not getting anywhere.

Also, nedmalloc fell unmaintained, so I don't necessarily think that it would be a good idea to spend a lot of time on it.

In the meantime, there is a much more viable contender: mi-malloc. Preliminary tests suggest that its performance on Windows is at least as good as nedmalloc's, and Windows was the use case for which we integrated nedmalloc into Git's compat/ in the first place.

I have tentative patches to integrate it into Git for Windows, and basically got side-tracked with other things. Expect to see something regarding mi-malloc from me in September.

Ciao, Dscho