git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/3] grep: no leaks (WIP)

From
Carlo Marcelo Arenas Belón <carenas@gmail.com>
Date
Aug 6, 2019, 08:50 UTC
Message-ID
<20190806085014.47776-1-carenas@gmail.com>
In-Reply-To
<xmqq36ifmg7v.fsf@gitster-ct.c.googlers.com>

This is an incomplete reroll for cb/pcre2-chartables-leakfix that attempts to address the root cause of the problem reported[1] by Dscho with PCRE2 and that is that until now PCRE and NED never worked together.

The first patch is likely correct but since I'd been unable to replicate the issue I can't be completely sure, if a kind soul with access to a windows developer environment could give it a try we will know for sure but FWIW it runs fine and doesn't introduce any failures in our tests

The second patch is obviously incomplete but should address the problem reported; there are still more things to consider as explained there

The third patch is the original leak patch rebased on top.
Carlo Marcelo Arenas Belón (3):
  grep: make PCRE1 aware of custom allocator
  grep: make PCRE2 aware of custom allocator
  grep: avoid leak of chartables in PCRE2
 Makefile       |  2 +-
 builtin/grep.c |  1 +
 grep.c         | 46 ++++++++++++++++++++++++++++++++++++++++++----
 grep.h         |  2 ++
 4 files changed, 46 insertions(+), 5 deletions(-)
[1] https://public-inbox.org/git/pull.306.git.gitgitgadget@gmail.com/
-- 
2.23.0.rc1
Previous: Carlo ArenasNext: Carlo Marcelo Arenas Belón
Message 9 of 67 in “Fix a problem with PCRE2 and nedmalloc, found via Azure Pipelines”
  1. 0/1 Fix a problem with PCRE2 and nedmalloc, found via Azure PipelinesJohannes Schindelin via GitGitGadget, Aug 5, 2019
  2. 1/1 pcre2: allow overriding the system allocatorJohannes Schindelin via GitGitGadget, Aug 5, 2019
  3. Carlo ArenasAug 5, 2019
  4. Carlo ArenasAug 5, 2019
  5. Johannes SchindelinAug 5, 2019
  6. Johannes SchindelinAug 5, 2019
  7. Junio C HamanoAug 5, 2019
  8. Carlo ArenasAug 6, 2019
  9. 0/3 grep: no leaks (WIP)Carlo Marcelo Arenas Belón, Aug 6, 2019
  10. 1/3 grep: make PCRE1 aware of custom allocatorCarlo Marcelo Arenas Belón, Aug 6, 2019
  11. Johannes SchindelinAug 8, 2019
  12. Carlo ArenasAug 8, 2019
  13. 3/3 grep: avoid leak of chartables in PCRE2Carlo Marcelo Arenas Belón, Aug 6, 2019
  14. 2/3 grep: make PCRE2 aware of custom allocatorCarlo Marcelo Arenas Belón, Aug 6, 2019
  15. Johannes SchindelinAug 8, 2019
  16. Carlo ArenasAug 8, 2019
  17. 0/3 grep: no leaks or crashes (windows testing needed)Carlo Marcelo Arenas Belón, Aug 6, 2019
  18. 2/3 grep: make PCRE2 aware of custom allocatorCarlo Marcelo Arenas Belón, Aug 6, 2019
  19. René ScharfeAug 7, 2019
  20. Carlo ArenasAug 7, 2019
  21. René ScharfeAug 7, 2019
  22. 1/2 nedmalloc: do assignments only after the declaration sectionRené Scharfe, Aug 7, 2019
  23. 2/2 nedmalloc: avoid compiler warning about unused valueRené Scharfe, Aug 7, 2019
  24. Carlo ArenasAug 8, 2019
  25. René ScharfeAug 8, 2019
  26. Carlo ArenasAug 8, 2019
  27. René ScharfeAug 8, 2019
  28. Johannes SchindelinAug 8, 2019
  29. Junio C HamanoAug 7, 2019
  30. 1/3 grep: make PCRE1 aware of custom allocatorCarlo Marcelo Arenas Belón, Aug 6, 2019
  31. 3/3 grep: avoid leak of chartables in PCRE2Carlo Marcelo Arenas Belón, Aug 6, 2019
  32. Junio C HamanoAug 6, 2019
  33. 0/3 grep: no leaks or crashes (windows testing needed)Carlo Marcelo Arenas Belón, Aug 7, 2019
  34. 1/3 grep: make PCRE1 aware of custom allocatorCarlo Marcelo Arenas Belón, Aug 7, 2019
  35. 2/3 grep: make PCRE2 aware of custom allocatorCarlo Marcelo Arenas Belón, Aug 7, 2019
  36. Junio C HamanoAug 7, 2019
  37. 3/3 grep: avoid leak of chartables in PCRE2Carlo Marcelo Arenas Belón, Aug 7, 2019
  38. 0/3 grep: almost no more leaks, hopefully no crashesCarlo Marcelo Arenas Belón, Aug 9, 2019
  39. 1/3 grep: make PCRE1 aware of custom allocatorCarlo Marcelo Arenas Belón, Aug 9, 2019
  40. 3/3 grep: avoid leak of chartables in PCRE2Carlo Marcelo Arenas Belón, Aug 9, 2019
  41. 2/3 grep: make PCRE2 aware of custom allocatorCarlo Marcelo Arenas Belón, Aug 9, 2019
  42. Johannes SchindelinAug 27, 2019
  43. Carlo ArenasAug 27, 2019
  44. Junio C HamanoOct 3, 2019
  45. Johannes SchindelinOct 3, 2019
  46. Carlo ArenasOct 3, 2019
  47. Johannes SchindelinOct 3, 2019
  48. Junio C HamanoOct 3, 2019
  49. Carlo ArenasAug 9, 2019
  50. René ScharfeAug 9, 2019
  51. Junio C HamanoAug 9, 2019
  52. Johannes SchindelinAug 9, 2019
  53. SQUASHCarlo Marcelo Arenas Belón, Aug 10, 2019
  54. René ScharfeAug 10, 2019
  55. Carlo ArenasAug 10, 2019
  56. René ScharfeAug 10, 2019
  57. Carlo ArenasAug 12, 2019
  58. René ScharfeAug 12, 2019
  59. Carlo ArenasAug 12, 2019
  60. Johannes SchindelinAug 10, 2019
  61. Carlo ArenasAug 10, 2019
  62. René ScharfeAug 10, 2019
  63. Carlo ArenasAug 10, 2019
  64. René ScharfeAug 10, 2019
  65. Johannes SchindelinAug 8, 2019
  66. Carlo ArenasAug 9, 2019
  67. Johannes SchindelinAug 9, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.