Re: [RFC PATCH v3 2/3] grep: make PCRE2 aware of custom allocator

From: René Scharfe <l.s.r@web.de>
Date: Aug 7, 2019, 13:02 UTC
Message-ID: <c7f08e19-88a7-ca7f-90b9-54465e621d49@web.de>
In-Reply-To: <CAPUEspip98Mq8FrKTOkEikZhaLPprZXf=E2x3d0b7=c7e5+Gyw@mail.gmail.com>

Am 07.08.19 um 11:49 schrieb Carlo Arenas:

> was hoping will perform better but it seems that testing can be done
> only in windows

nedmalloc works on other platforms as well. On Debian Testing with GCC 9.1.0 I need two changes to suppress some compiler warnings, though. Will post them as replies.

"make USE_NED_ALLOCATOR=1 test" then reports these failures:

t7816-grep-binary-pattern.sh                     (Wstat: 256 Tests: 145 Failed: 5)
  Failed tests:  48, 54, 57, 60, 63
  Non-zero exit status: 1

And the first one when running that test with --verbose and --immediate is showing:

BUG: grep.c:510: pcre2_global_context uninitialized
Aborted
not ok 48 - LC_ALL='C' git grep -P -f f -i '[æ]<NUL>ð' a
#
#				printf '[æ]Qð' | q_to_nul >f &&
#				LC_ALL='C' git grep -P -f f -i a
#