git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 19/20] diff --no-index: use parse_options() instead of diff_opt_parse()

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Apr 30, 2019, 01:02 UTC
Message-ID
<nycvar.QRO.7.76.6.1904292055300.45@tvgsbejvaqbjf.bet>
In-Reply-To
<20190324082014.2041-20-pclouds@gmail.com>
Hi Duy,
On Sun, 24 Mar 2019, Nguyễn Thái Ngọc Duy wrote:
> While at there, move exit() back to the caller. It's easier to see the
> flow that way than burying it in diff-no-index.c

I just noticed that this commit message is missing more than just a trailing period. It does not explain the change of behavior: previously, `GIT_EXTERNAL_DIFF=heya git diff --no-index a b` would silently ignore the external diff, it would have required an explicit `--ext-diff` to pick it up.

After this change, it is necessary to pass `--no-ext-diff` to reinstate the original behavior.

While this might seem like a desirable change, it is a backwards-incompatible change and would do with a *lot* more of a message to users whose scripts now potentially break.

Ciao, Johannes

Previous: Nguyễn Thái Ngọc DuyNext: Duy Nguyen
Message 47 of 52 in “nd/diff-parseopt the last part”
  1. 00/20 nd/diff-parseopt the last partNguyễn Thái Ngọc Duy, Mar 20, 2019
  2. 01/20 diff-parseopt: convert --ws-error-highlightNguyễn Thái Ngọc Duy, Mar 20, 2019
  3. Martin ÅgrenMar 20, 2019
  4. 02/20 diff-parseopt: convert --ita-[in]visible-in-indexNguyễn Thái Ngọc Duy, Mar 20, 2019
  5. 03/20 diff-parseopt: convert -zNguyễn Thái Ngọc Duy, Mar 20, 2019
  6. 04/20 diff-parseopt: convert -lNguyễn Thái Ngọc Duy, Mar 20, 2019
  7. 05/20 diff-parseopt: convert -S|-GNguyễn Thái Ngọc Duy, Mar 20, 2019
  8. 06/20 diff-parseopt: convert --pickaxe-all|--pickaxe-regexNguyễn Thái Ngọc Duy, Mar 20, 2019
  9. 07/20 diff-parseopt: convert -ONguyễn Thái Ngọc Duy, Mar 20, 2019
  10. Martin ÅgrenMar 20, 2019
  11. 08/20 diff-parseopt: convert --find-objectNguyễn Thái Ngọc Duy, Mar 20, 2019
  12. 09/20 diff-parseopt: convert --diff-filterNguyễn Thái Ngọc Duy, Mar 20, 2019
  13. 10/20 diff-parseopt: convert --[no-]abbrevNguyễn Thái Ngọc Duy, Mar 20, 2019
  14. Ævar Arnfjörð BjarmasonMar 20, 2019
  15. Duy NguyenMar 21, 2019
  16. 11/20 diff-parseopt: convert --[src|dst]-prefixNguyễn Thái Ngọc Duy, Mar 20, 2019
  17. 12/20 diff-parseopt: convert --line-prefixNguyễn Thái Ngọc Duy, Mar 20, 2019
  18. 13/20 diff-parseopt: convert --no-prefixNguyễn Thái Ngọc Duy, Mar 20, 2019
  19. Martin ÅgrenMar 20, 2019
  20. 14/20 diff-parseopt: convert --inter-hunk-contextNguyễn Thái Ngọc Duy, Mar 20, 2019
  21. 15/20 diff-parseopt: convert --[no-]color-movedNguyễn Thái Ngọc Duy, Mar 20, 2019
  22. 16/20 diff-parseopt: convert --color-moved-wsNguyễn Thái Ngọc Duy, Mar 20, 2019
  23. 17/20 diff.c: allow --no-color-moved-wsNguyễn Thái Ngọc Duy, Mar 20, 2019
  24. 18/20 range-diff: use parse_options() instead of diff_opt_parse()Nguyễn Thái Ngọc Duy, Mar 20, 2019
  25. 19/20 diff --no-index: use parse_options() instead of diff_opt_parse()Nguyễn Thái Ngọc Duy, Mar 20, 2019
  26. 20/20 am: avoid diff_opt_parse()Nguyễn Thái Ngọc Duy, Mar 20, 2019
  27. 00/20 nd/diff-parseopt the last partNguyễn Thái Ngọc Duy, Mar 24, 2019
  28. 01/20 diff-parseopt: convert --ws-error-highlightNguyễn Thái Ngọc Duy, Mar 24, 2019
  29. 02/20 diff-parseopt: convert --ita-[in]visible-in-indexNguyễn Thái Ngọc Duy, Mar 24, 2019
  30. 03/20 diff-parseopt: convert -zNguyễn Thái Ngọc Duy, Mar 24, 2019
  31. 04/20 diff-parseopt: convert -lNguyễn Thái Ngọc Duy, Mar 24, 2019
  32. 05/20 diff-parseopt: convert -S|-GNguyễn Thái Ngọc Duy, Mar 24, 2019
  33. 06/20 diff-parseopt: convert --pickaxe-all|--pickaxe-regexNguyễn Thái Ngọc Duy, Mar 24, 2019
  34. 07/20 diff-parseopt: convert -ONguyễn Thái Ngọc Duy, Mar 24, 2019
  35. 08/20 diff-parseopt: convert --find-objectNguyễn Thái Ngọc Duy, Mar 24, 2019
  36. 09/20 diff-parseopt: convert --diff-filterNguyễn Thái Ngọc Duy, Mar 24, 2019
  37. 10/20 diff-parseopt: convert --[no-]abbrevNguyễn Thái Ngọc Duy, Mar 24, 2019
  38. 11/20 diff-parseopt: convert --[src|dst]-prefixNguyễn Thái Ngọc Duy, Mar 24, 2019
  39. 12/20 diff-parseopt: convert --line-prefixNguyễn Thái Ngọc Duy, Mar 24, 2019
  40. 13/20 diff-parseopt: convert --no-prefixNguyễn Thái Ngọc Duy, Mar 24, 2019
  41. 14/20 diff-parseopt: convert --inter-hunk-contextNguyễn Thái Ngọc Duy, Mar 24, 2019
  42. 15/20 diff-parseopt: convert --[no-]color-movedNguyễn Thái Ngọc Duy, Mar 24, 2019
  43. 16/20 diff-parseopt: convert --color-moved-wsNguyễn Thái Ngọc Duy, Mar 24, 2019
  44. 17/20 diff.c: allow --no-color-moved-wsNguyễn Thái Ngọc Duy, Mar 24, 2019
  45. 18/20 range-diff: use parse_options() instead of diff_opt_parse()Nguyễn Thái Ngọc Duy, Mar 24, 2019
  46. 19/20 diff --no-index: use parse_options() instead of diff_opt_parse()Nguyễn Thái Ngọc Duy, Mar 24, 2019
  47. Johannes SchindelinApr 30, 2019
  48. Duy NguyenApr 30, 2019
  49. Johannes SchindelinApr 30, 2019
  50. Duy NguyenMay 1, 2019
  51. Jeff KingMay 1, 2019
  52. 20/20 am: avoid diff_opt_parse()Nguyễn Thái Ngọc Duy, Mar 24, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.