From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Tue, 30 Apr 2019 01:02:28 GMT
Subject: Re: [PATCH v2 19/20] diff --no-index: use parse_options() instead of diff_opt_parse()
Message-ID: <nycvar.QRO.7.76.6.1904292055300.45@tvgsbejvaqbjf.bet>
In-Reply-To: <20190324082014.2041-20-pclouds@gmail.com>

Hi Duy,

On Sun, 24 Mar 2019, Nguyễn Thái Ngọc Duy wrote:

> While at there, move exit() back to the caller. It's easier to see the
> flow that way than burying it in diff-no-index.c

I just noticed that this commit message is missing more than just a
trailing period. It does not explain the change of behavior: previously,
`GIT_EXTERNAL_DIFF=heya git diff --no-index a b` would silently ignore the
external diff, it would have required an explicit `--ext-diff` to pick it
up.

After this change, it is necessary to pass `--no-ext-diff` to reinstate
the original behavior.

While this might seem like a desirable change, it is a
backwards-incompatible change and would do with a *lot* more of a message
to users whose scripts now potentially break.

Ciao,
Johannes