Re: [PATCH v2 19/20] diff --no-index: use parse_options() instead of diff_opt_parse()

From: Duy Nguyen <pclouds@gmail.com>
Date: Apr 30, 2019, 04:53 UTC
Message-ID: <CACsJy8CUNVWqWff05Lg2xjnOj3L2T7RvVbZh+RZPjvFokvT_-A@mail.gmail.com>
In-Reply-To: <nycvar.QRO.7.76.6.1904292055300.45@tvgsbejvaqbjf.bet>

On Tue, Apr 30, 2019 at 8:02 AM Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:

Show 13 quoted lines

>
> Hi Duy,
>
> On Sun, 24 Mar 2019, Nguyễn Thái Ngọc Duy wrote:
>
> > While at there, move exit() back to the caller. It's easier to see the
> > flow that way than burying it in diff-no-index.c
>
> I just noticed that this commit message is missing more than just a
> trailing period. It does not explain the change of behavior: previously,
> `GIT_EXTERNAL_DIFF=heya git diff --no-index a b` would silently ignore the
> external diff, it would have required an explicit `--ext-diff` to pick it
> up.

Because I was not aware of the behavior change.

-- 
Duy