Re: [PATCH v2 19/20] diff --no-index: use parse_options() instead of diff_opt_parse()

From: Jeff King <peff@peff.net>
Date: May 1, 2019, 18:46 UTC
Message-ID: <20190501184658.GH4109@sigill.intra.peff.net>
In-Reply-To: <CACsJy8AGf81=_BTd6+idnBcHPB2AAj=dciJn6r_rCB8TJ1hvug@mail.gmail.com>

On Wed, May 01, 2019 at 04:53:44PM +0700, Duy Nguyen wrote:

Show 10 quoted lines

> > > > I just noticed that this commit message is missing more than just a
> > > > trailing period. It does not explain the change of behavior: previously,
> > > > `GIT_EXTERNAL_DIFF=heya git diff --no-index a b` would silently ignore the
> > > > external diff, it would have required an explicit `--ext-diff` to pick it
> > > > up.
> [...]
> Bisecting points to 287ab28bfa (diff: reuse diff setup for --no-index
> case, 2019-02-16). From the description (i.e. "miss out some settings
> like --ext-diff...") the behavior change seems delibrate. Adding Jeff
> for clarification/

Yeah, that was the purpose of that change: whether in no-index mode or not, git-diff should behave consistently.

-Peff