Re: [PATCH] run-command: report exec failure
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Dec 11, 2018, 12:31 UTC
- Message-ID
- <nycvar.QRO.7.76.6.1812111327460.43@tvgsbejvaqbjf.bet>
- In-Reply-To
- <xmqqd0q8liow.fsf@gitster-ct.c.googlers.com>
Hi Junio,
On Tue, 11 Dec 2018, Junio C Hamano wrote:
Show 11 quoted lines
> diff --git a/t/t0061-run-command.sh b/t/t0061-run-command.sh > index cf932c8514..9c83d44d9c 100755 > --- a/t/t0061-run-command.sh > +++ b/t/t0061-run-command.sh > @@ -13,11 +13,13 @@ cat >hello-script <<-EOF > EOF > > test_expect_success 'start_command reports ENOENT (slash)' ' > - test-tool run-command start-command-ENOENT ./does-not-exist > + test-tool run-command start-command-ENOENT ./does-not-exist 2>err && > + test_i18ngrep "cannot run" err
This breaks on Windows (on Windows, the error message says "cannot spawn", see https://dev.azure.com/git-for-windows/git/_build/results?buildId=26917):
-- snipsnap -- [...] 2018-12-11T11:13:59.9924183Z ++ grep 'cannot run' err 2018-12-11T11:14:00.0092569Z ++ echo 'error: '\''grep cannot run' 'err'\'' didn'\''t find a match in:' 2018-12-11T11:14:00.0099500Z error: 'grep cannot run err' didn't find a match in: 2018-12-11T11:14:00.0100663Z ++ test -s err 2018-12-11T11:14:00.0101058Z ++ cat err 2018-12-11T11:14:00.0239691Z error: cannot spawn ./does-not-exist: No such file or directory 2018-12-11T11:14:00.0254289Z ++ return 1 2018-12-11T11:14:00.0254489Z not ok 1 - start_command reports ENOENT (slash) 2018-12-11T11:14:00.0258844Z error: last command exited with $?=1 2018-12-11T11:14:00.0472195Z # 2018-12-11T11:14:00.0473619Z # test-tool run-command start-command-ENOENT ./does-not-exist 2>err && 2018-12-11T11:14:00.0473874Z # test_i18ngrep "cannot run" err 2018-12-11T11:14:00.0474098Z #