Re: [PATCH] run-command: report exec failure
- From
John Passaro <john.a.passaro@gmail.com>
- Date
- Dec 12, 2018, 15:27 UTC
- Message-ID
- <CAJdN7Khf+Y_jyyG2qoqiMHYPCHHSws15EDftOQni=gFJ7SoMXg@mail.gmail.com>
- In-Reply-To
- <xmqqsgz4jkgl.fsf@gitster-ct.c.googlers.com>
Thank you for this incredibly quick fix.
I see the fix made it to pu as 6b206be3e5 ("run-command: report exec failure" 2018-12-11). For what it's worth, it fixes the issue as far as I'm concerned and I'm very glad to see the behavior is covered by tests now.
As a procedural question: I'd like to reference this patch in one of my own. Can I reference it as I typed it above? Or is there a chance of the SHA1 changing before it goes into some sort of a main history?
John Passaro (917) 678-8293 On Tue, Dec 11, 2018 at 7:50 AM Junio C Hamano <gitster@pobox.com> wrote:
Show 7 quoted lines
> > Johannes Schindelin <Johannes.Schindelin@gmx.de> writes: > > > This breaks on Windows (on Windows, the error message says "cannot spawn", see > > Thanks for a quick feedback. Let's update to look for the pathname > of the command, as Peff suggested earlier.