Re: [PATCH] run-command: report exec failure

From: Jeff King <peff@peff.net>
Date: Dec 13, 2018, 08:10 UTC
Message-ID: <20181213081057.GC12132@sigill.intra.peff.net>
In-Reply-To: <CAJdN7Khf+Y_jyyG2qoqiMHYPCHHSws15EDftOQni=gFJ7SoMXg@mail.gmail.com>

On Wed, Dec 12, 2018 at 10:27:40AM -0500, John Passaro wrote:

Show 10 quoted lines

> Thank you for this incredibly quick fix.
> 
> I see the fix made it to pu as 6b206be3e5 ("run-command: report exec
> failure" 2018-12-11).  For what it's worth, it fixes the issue as far
> as I'm concerned and I'm very glad to see the behavior is covered by
> tests now.
> 
> As a procedural question: I'd like to reference this patch in one of
> my own. Can I reference it as I typed it above? Or is there a chance
> of the SHA1 changing before it goes into some sort of a main history?

Commits in "pu" are still subject to change (and indeed, this one was amended to e5a329a279 to fix the grep issue on Windows).

Once it hits "next" it is generally stable. That hasn't happened yet, but I think what's there now is likely to get merged as-is (and will retain that commit id).

-Peff