Re: [PATCH v2] run-command: report exec failure

From: Jeff King <peff@peff.net>
Date: Dec 13, 2018, 08:08 UTC
Message-ID: <20181213080825.GB12132@sigill.intra.peff.net>
In-Reply-To: <xmqqbm5qioca.fsf_-_@gitster-ct.c.googlers.com>

On Thu, Dec 13, 2018 at 03:36:53AM +0900, Junio C Hamano wrote:

Show 12 quoted lines

> In 321fd823 ("run-command: mark path lookup errors with ENOENT",
> 2018-10-24), we rewrote the logic to execute a command by looking
> in the directories on $PATH; as a side effect, a request to run a
> command that is not found on $PATH is noticed even before a child
> process is forked to execute it.
> 
> We however stopped to report an exec failure in such a case by
> mistake.  Add a logic to report the error unless silent-exec-failure
> is requested, to match the original code.
> 
> Reported-by: John Passaro <john.a.passaro@gmail.com>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Thanks, this looks good to me.

Show 5 quoted lines

>  test_expect_success 'start_command reports ENOENT (slash)' '
> -	test-tool run-command start-command-ENOENT ./does-not-exist
> +	test-tool run-command start-command-ENOENT ./does-not-exist 2>err &&
> +	test_i18ngrep "\./does-not-exist" err
>  '

I thought at first you could use "grep" here, since we know that the name of the file would appear untranslated. But I think the way GETTEXT_POISON works, it actually eats the whole string, including placeholders (which IMHO is a failing of GETTEXT_POISON, since no real translation would do that, but not worth caring too much about).

-Peff