RE: [PATCH v3 1/3] reset: don't compute unstaged changes after reset when --quiet
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Oct 23, 2018, 08:53 UTC
- Message-ID
- <nycvar.QRO.7.76.6.1810231052410.4546@tvgsbejvaqbjf.bet>
- In-Reply-To
- <MW2PR2101MB0970EF1065717A38CF581C64F4F40@MW2PR2101MB0970.namprd21.prod.outlook.com>
Hi Ben,
On Mon, 22 Oct 2018, Ben Peart wrote:
Show 20 quoted lines
> > From: Johannes Schindelin <Johannes.Schindelin@gmx.de> > > > > On Mon, 22 Oct 2018, Ben Peart wrote: > > > > > When git reset is run with the --quiet flag, don't bother finding > > > any additional unstaged changes as they won't be output anyway. > > > This speeds up the git reset command by avoiding having to lstat() > > > every file looking for changes that aren't going to be reported > > > anyway. > > > > > > The savings can be significant. In a repo with 200K files "git > > > reset" drops from 7.16 seconds to 0.32 seconds for a savings of 96%. > > > > That's very nice! > > > > Those numbers, just out of curiosity, are they on Windows? Or on > > Linux? > > > > It's safe to assume all my numbers are on Windows. :-)
Excellent. These speed-ups will really help our users.
Thanks! Dscho