git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 2/3] reset: add new reset.quiet config setting

From
Ramsay Jones <ramsay@ramsayjones.plus.com>
Date
Oct 22, 2018, 19:13 UTC
Message-ID
<045b78ce-230e-86fe-6e5a-684bf9e93fbc@ramsayjones.plus.com>
In-Reply-To
<20181022131828.21348-3-peartben@gmail.com>
On 22/10/2018 14:18, Ben Peart wrote:
Show 40 quoted lines
> From: Ben Peart <benpeart@microsoft.com>
> 
> Add a reset.quiet config setting that sets the default value of the --quiet
> flag when running the reset command.  This enables users to change the
> default behavior to take advantage of the performance advantages of
> avoiding the scan for unstaged changes after reset.  Defaults to false.
> 
> Signed-off-by: Ben Peart <benpeart@microsoft.com>
> ---
>  Documentation/config.txt    | 3 +++
>  Documentation/git-reset.txt | 4 +++-
>  builtin/reset.c             | 1 +
>  3 files changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/config.txt b/Documentation/config.txt
> index f6f4c21a54..a2d1b8b116 100644
> --- a/Documentation/config.txt
> +++ b/Documentation/config.txt
> @@ -2728,6 +2728,9 @@ rerere.enabled::
>  	`$GIT_DIR`, e.g. if "rerere" was previously used in the
>  	repository.
>  
> +reset.quiet::
> +	When set to true, 'git reset' will default to the '--quiet' option.
> +
>  include::sendemail-config.txt[]
>  
>  sequence.editor::
> diff --git a/Documentation/git-reset.txt b/Documentation/git-reset.txt
> index 1d697d9962..51a427a34a 100644
> --- a/Documentation/git-reset.txt
> +++ b/Documentation/git-reset.txt
> @@ -95,7 +95,9 @@ OPTIONS
>  
>  -q::
>  --quiet::
> -	Be quiet, only report errors.
> +--no-quiet::
> +	Be quiet, only report errors. The default behavior respects the
> +	`reset.quiet` config option, or `--no-quiet` if that is not set.

Sorry, I can't quite parse this; -q,--quiet and --no-quiet on the command line (should) trump whatever rest.quiet is set to in the configuration. Is that not the case?

ATB, Ramsay Jones

Show 16 quoted lines
>  
>  
>  EXAMPLES
> diff --git a/builtin/reset.c b/builtin/reset.c
> index 04f0d9b4f5..3b43aee544 100644
> --- a/builtin/reset.c
> +++ b/builtin/reset.c
> @@ -306,6 +306,7 @@ int cmd_reset(int argc, const char **argv, const char *prefix)
>  	};
>  
>  	git_config(git_reset_config, NULL);
> +	git_config_get_bool("reset.quiet", &quiet);
>  
>  	argc = parse_options(argc, argv, prefix, options, git_reset_usage,
>  						PARSE_OPT_KEEP_DASHDASH);
> 
Previous: Duy NguyenNext: Jeff King
Message 48 of 63 in “speed up git reset”
  1. 0/2 speed up git resetBen Peart, Oct 17, 2018
  2. 1/2 reset: don't compute unstaged changes after reset when --quietBen Peart, Oct 17, 2018
  3. Eric SunshineOct 17, 2018
  4. Jeff KingOct 17, 2018
  5. Junio C HamanoOct 18, 2018
  6. Jeff KingOct 18, 2018
  7. Ben PeartOct 18, 2018
  8. Duy NguyenOct 18, 2018
  9. Ben PeartOct 18, 2018
  10. Junio C HamanoOct 19, 2018
  11. 2/2 reset: add new reset.quietDefault config settingBen Peart, Oct 17, 2018
  12. Eric SunshineOct 17, 2018
  13. Jeff KingOct 17, 2018
  14. Ævar Arnfjörð BjarmasonOct 23, 2018
  15. Ben PeartOct 23, 2018
  16. Jeff KingOct 23, 2018
  17. Ævar Arnfjörð BjarmasonOct 23, 2018
  18. Recommended configurations (was Re: [PATCH v1 2/2] reset: add new reset.quietDefault config setting)Derrick Stolee, Oct 24, 2018
  19. Jeff KingOct 24, 2018
  20. Junio C HamanoOct 25, 2018
  21. 0/3 speed up git resetBen Peart, Oct 19, 2018
  22. 1/3 reset: don't compute unstaged changes after reset when --quietBen Peart, Oct 19, 2018
  23. 2/3 reset: add new reset.quiet config settingBen Peart, Oct 19, 2018
  24. Eric SunshineOct 19, 2018
  25. Jeff KingOct 19, 2018
  26. Eric SunshineOct 19, 2018
  27. Jeff KingOct 19, 2018
  28. Ben PeartOct 19, 2018
  29. Jeff KingOct 19, 2018
  30. Junio C HamanoOct 22, 2018
  31. Ben PeartOct 19, 2018
  32. 3/3 reset: warn when refresh_index() takes more than 2 secondsBen Peart, Oct 19, 2018
  33. 0/3 speed up git resetBen Peart, Oct 22, 2018
  34. 1/3 reset: don't compute unstaged changes after reset when --quietBen Peart, Oct 22, 2018
  35. Johannes SchindelinOct 22, 2018
  36. Ben PeartOct 22, 2018
  37. Johannes SchindelinOct 23, 2018
  38. Duy NguyenOct 23, 2018
  39. Johannes SchindelinOct 23, 2018
  40. 2/3 reset: add new reset.quiet config settingBen Peart, Oct 22, 2018
  41. Duy NguyenOct 22, 2018
  42. Ben PeartOct 23, 2018
  43. Junio C HamanoOct 24, 2018
  44. Junio C HamanoOct 24, 2018
  45. Duy NguyenOct 24, 2018
  46. Junio C HamanoOct 25, 2018
  47. Duy NguyenOct 24, 2018
  48. Ramsay JonesOct 22, 2018
  49. Jeff KingOct 22, 2018
  50. Ben PeartOct 23, 2018
  51. Jeff KingOct 23, 2018
  52. 3/3 reset: warn when refresh_index() takes more than 2 secondsBen Peart, Oct 22, 2018
  53. Junio C HamanoOct 23, 2018
  54. Ben PeartOct 23, 2018
  55. 0/3 speed up git resetBen Peart, Oct 23, 2018
  56. 1/3 reset: don't compute unstaged changes after reset when --quietBen Peart, Oct 23, 2018
  57. 2/3 reset: add new reset.quiet config settingBen Peart, Oct 23, 2018
  58. Ramsay JonesOct 24, 2018
  59. Junio C HamanoOct 25, 2018
  60. Junio C HamanoOct 25, 2018
  61. Ben PeartOct 25, 2018
  62. Ramsay JonesOct 25, 2018
  63. 3/3 reset: warn when refresh_index() takes more than 2 secondsBen Peart, Oct 23, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.