Re: [PATCH v4 2/3] reset: add new reset.quiet config setting
- From
Ramsay Jones <ramsay@ramsayjones.plus.com>
- Date
- Oct 25, 2018, 17:04 UTC
- Message-ID
- <47378681-3d7d-97fd-cf2a-4a0fe344a9e1@ramsayjones.plus.com>
- In-Reply-To
- <xmqqbm7igyw6.fsf@gitster-ct.c.googlers.com>
On 25/10/2018 10:26, Junio C Hamano wrote:
Show 24 quoted lines
> Junio C Hamano <gitster@pobox.com> writes: > >> To be honest, I find the second sentence in your rewrite even more >> confusing. It reads as if `reset.quiet` configuration variable >> can be used to restore the "show what is yet to be added" >> behaviour, due to the parenthetical mention of the default behaviour >> without any configuration. >> >> The command reports what is yet to be added to the index >> after `reset` by default. It can be made to only report >> errors with the `--quiet` option, or setting `reset.quiet` >> configuration variable to `true` (the latter can be >> overriden with `--no-quiet`). >> >> That may not be much better, though X-<. > > In any case, the comments are getting closer to the bikeshedding > territory, that can be easily addressed incrementally. I am getting > the impression that everbody agrees that the change is desirable, > sufficiently documented and properly implemented. > > Shall we mark it for "Will merge to 'next'" in the what's cooking > report and leave further refinements to incremental updates as > needed?
Yeah, the first version gave me a 'huh?' moment (hence the comment), the last version was better and, as you can see, I am no great shakes at wordsmith-ing documentation! ;-)
Thanks!
ATB, Ramsay Jones