Re: [PATCH v2 2/3] reset: add new reset.quiet config setting

From: Jeff King <peff@peff.net>
Date: Oct 19, 2018, 19:08 UTC
Message-ID: <20181019190856.GC24418@sigill.intra.peff.net>
In-Reply-To: <38b9f813-0463-3d15-ad9d-86f64c140043@gmail.com>

On Fri, Oct 19, 2018 at 01:23:06PM -0400, Ben Peart wrote:

Show 12 quoted lines

> > > Okay. In any case, --no-quiet probably ought to be mentioned alongside
> > > the "reset.quiet" option (and perhaps in git-reset.txt to as a way to
> > > reverse "reset.quiet").
> [...]
> Makes sense.  I'll update the docs to say:
> 
> -q::
> --quiet::
> --no-quiet::
> 	Be quiet, only report errors.
> +
> With --no-quiet report errors and unstaged changes after reset.

I think we should be explicit that "--no-quiet" is already the default, which makes it easy to mention the config option. Something like:

  -q::
  --quiet::
  --no-quiet::
	Be quiet, only report errors. The default behavior respects the
	`reset.quiet` config option, or `--no-quiet` if that is not set.

I don't know if we need to mention the "unstaged changes" thing. We may grow other non-error messages (or may even have some now, I didn't check). But I'm OK including it, too.

-Peff