Re: [GSoC][PATCH v8 17/20] stash: convert save to builtin
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Sep 3, 2018, 20:38 UTC
- Message-ID
- <nycvar.QRO.7.76.6.1809032238240.71@tvgsbejvaqbjf.bet>
- In-Reply-To
- <CAPig+cTGBi1P5V3uGwtKCvoCn=-17y1dY3dBkS13Yx1ikjpXcQ@mail.gmail.com>
Hi Eric,
On Mon, 3 Sep 2018, Eric Sunshine wrote:
Show 15 quoted lines
> On Mon, Sep 3, 2018 at 2:44 PM Johannes Schindelin
> <Johannes.Schindelin@gmx.de> wrote:
> > where `strbuf_join_argv()` would be implemented like this (and I would put
> > it into strbuf.c and strbuf.h:
> >
> > const char *strbuf_join_argv(struct strbuf *buf,
> > int argc, const char **argv, char delim)
> > {
> > if (!argc)
> > return buf->buf;
> >
> > strbuf_addstr(buf, *argv);
> > while (--i) {
>
> s/i/argc/Right you are!
Thank you, Dscho
Show 8 quoted lines
> > > strbuf_addch(buf, delim); > > strbuf_addstr(buf, *(++argv); > > } > > > > return buf->buf; > > } >