Re: [PATCH v5 1/5] stash: improve option parsing test coverage
- From
Paul-Sebastian Ungureanu <ungureanupaulsebastian@gmail.com>
- Date
- Apr 6, 2018, 22:48 UTC
- Message-ID
- <a64d281b-a18c-7c6c-1524-92aef869209f@gmail.com>
- In-Reply-To
- <nycvar.QRO.7.76.6.1804061439100.55@ZVAVAG-6OXH6DA.rhebcr.pbec.zvpebfbsg.pbz>
On 06.04.2018 16:06, Johannes Schindelin wrote:
Show 17 quoted lines
>> + git stash clear &&
>> + test_when_finished "git reset --hard HEAD" &&
>> + echo foo >file2 &&
>> + git stash &&
>> + echo bar >file2 &&
>> + git stash &&
>> + test-chmtime =123456789 file2 &&
>> + for type in apply pop "branch stash-branch"
>> + do
>> + test_must_fail git stash $type stash@{0} stash@{1} 2>err &&
>> + test_i18ngrep "Too many" err &&
>> + test 123456789 = $(test-chmtime -v +0 file2 | sed 's/[^0-9].*$//') || return 1
>
> Not your problem, but if there is future work on this (read: if I get to
> mentor a GSoC student, and if I get them to work on it: this idiom
> `test-chmtime -v +0 ... | sed ...` is too common, there really *should* be
> a `test-chmtime --get ...`).Hi,
I submitted a patch for this [1].
[1] https://public-inbox.org/git/20180406221947.28402-1-ungureanupaulsebastian@gmail.com/
Best regards, Paul Ungureanu