Re: [GSoC][PATCH v7 05/26] stash: convert apply to builtin

From: Paul-Sebastian Ungureanu <ungureanupaulsebastian@gmail.com>
Date: Aug 10, 2018, 15:35 UTC
Message-ID: <60b38370-b8ac-fe13-abf7-db3166a04dee@gmail.com>
In-Reply-To: <xmqqftznb6hc.fsf@gitster-ct.c.googlers.com>

Hellom

On 10.08.2018 00:00, Junio C Hamano wrote:

Show 10 quoted lines

> Paul-Sebastian Ungureanu <ungureanupaulsebastian@gmail.com> writes:
> 
>>> Good to see that the right way to forward a patch from another
>>> person is used, but is this a GSoC project?
>>
>> Yes, it is. I forgot to add the [GSoC] tag in the last series of patches.
> 
> The reason I asked was because IIRC GSoC was not supposed to be team
> effort but "summer job" by individual students.
>

Before starting working on this, I discussed with Joel and ask him whether I could take custody of this patches. He was open to the idea, so I continued to build on top of them. Since then, I have made some changes to his code and also added a lot more of my own.

What I did was to completely convert git stash and apply some more optimizations on top of that, like reducing the number of spawned processes. Due to this kind of improvements I was able to significantly reduce the execution time and this has visible effects, running about 3 times faster.

Please do not get me wrong, I do not want to bash Joel or his work. I just wanted to make it clear that I did not copy his work or made it look like it was mine. After Joel agreed to hand the patches off to me [1], every line of code that I wrote was written by myself, without his (or anyone else) assistance. I really did my best to finish this project and I believe that my mentor, dscho, can also confirm this. I am really sorry for the confusion.

[1] https://public-inbox.org/git/CA+CzEk_qwHs5qUstyFeepzwvCBR=9SvH90+__f-gfxFySETZzQ@mail.gmail.com/

Best regards, Paul Ungureanu