git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/1] Teach the builtin rebase about the builtin interactive rebase

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Aug 29, 2018, 14:29 UTC
Message-ID
<nycvar.QRO.7.76.6.1808291525130.71@tvgsbejvaqbjf.bet>
In-Reply-To
<20180828171748.GC23314@aiede.svl.corp.google.com>
Hi Jonathan,
On Tue, 28 Aug 2018, Jonathan Nieder wrote:
Show 30 quoted lines
> Johannes Schindelin wrote:
> > On Mon, 27 Aug 2018, Junio C Hamano wrote:
> >> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> >>> Jonathan Nieder wrote:
> 
> >>>> Please include this information in the commit message.  It's super
> >>>> helpful to find this kind of information about why a patch does what
> >>>> it does when encountering a patch later "in the wild" (in git log -S
> >>>> output).
> [...]
> >> I think what Jonathan finds helpful is the other half of the story
> >
> > I will await Jonathan's clarification.
> 
> Junio's understanding is correct.
> 
> More generally, I greatly appreciate the kind of motivation and
> backstory that you write in cover letters, and I wish that more of
> that would find its way into the commit messages instead.  Really I
> wish (and don't take this the wrong way --- I am not asking you to
> write it unless it's your own itch) that GitGitGadget would put the
> cover letter in single-patch series after the "---" line in the
> individual patches, since that would make it easier for reviewers to
> point out what content from the cover letter would be useful to add to
> the commit message.
> 
> That said, this is minor and not a reason to reroll this patch.  It was
> more that I wanted to give the hint for later patches.
> 
> Thanks much and hope that helps,
It does.

I'll "rick-roll" a new iteration, as I just realized that (contrary to my recollection; I guess I'll need that vacation) the commit message is *seriously* lacking. I thought I had remembered that I copy-edited the commit message into the PR description. Clearly that was not the case.

Thanks for the clarification that triggered my looking, Dscho

Previous: Jonathan NiederNext: Johannes Schindelin via GitGitGadget
Message 11 of 22 in “Teach the builtin rebase about the builtin interactive rebase”
  1. 0/1 Teach the builtin rebase about the builtin interactive rebaseJohannes Schindelin via GitGitGadget, Aug 22, 2018
  2. 1/1 builtin rebase: prepare for builtin rebase -iJohannes Schindelin via GitGitGadget, Aug 22, 2018
  3. Junio C HamanoAug 22, 2018
  4. Jonathan NiederAug 23, 2018
  5. Johannes SchindelinAug 25, 2018
  6. Junio C HamanoAug 27, 2018
  7. Johannes SchindelinAug 28, 2018
  8. Junio C HamanoAug 28, 2018
  9. Johannes SchindelinAug 29, 2018
  10. Jonathan NiederAug 28, 2018
  11. Johannes SchindelinAug 29, 2018
  12. 0/1 Teach the builtin rebase about the builtin interactive rebaseJohannes Schindelin via GitGitGadget, Aug 29, 2018
  13. 1/1 builtin rebase: prepare for builtin rebase -iJohannes Schindelin via GitGitGadget, Aug 29, 2018
  14. Junio C HamanoAug 29, 2018
  15. Johannes SchindelinAug 30, 2018
  16. Jeff KingAug 30, 2018
  17. Johannes SchindelinAug 31, 2018
  18. Jeff KingAug 31, 2018
  19. 0/1 Teach the builtin rebase about the builtin interactive rebaseJohannes Schindelin via GitGitGadget, Oct 5, 2018
  20. 1/1 builtin rebase: prepare for builtin rebase -iJohannes Schindelin via GitGitGadget, Oct 5, 2018
  21. Junio C HamanoOct 6, 2018
  22. Johannes SchindelinOct 12, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.