Re: [PATCH 0/1] Teach the builtin rebase about the builtin interactive rebase

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Aug 28, 2018, 17:17 UTC
Message-ID: <20180828171748.GC23314@aiede.svl.corp.google.com>
In-Reply-To: <nycvar.QRO.7.76.6.1808281451191.73@tvgsbejvaqbjf.bet>

Johannes Schindelin wrote:

> On Mon, 27 Aug 2018, Junio C Hamano wrote:
>> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>>> Jonathan Nieder wrote:

>>>> Please include this information in the commit message.  It's super
>>>> helpful to find this kind of information about why a patch does what
>>>> it does when encountering a patch later "in the wild" (in git log -S
>>>> output).

[...]

>> I think what Jonathan finds helpful is the other half of the story
>
> I will await Jonathan's clarification.

Junio's understanding is correct.

More generally, I greatly appreciate the kind of motivation and backstory that you write in cover letters, and I wish that more of that would find its way into the commit messages instead. Really I wish (and don't take this the wrong way --- I am not asking you to write it unless it's your own itch) that GitGitGadget would put the cover letter in single-patch series after the "---" line in the individual patches, since that would make it easier for reviewers to point out what content from the cover letter would be useful to add to the commit message.

That said, this is minor and not a reason to reroll this patch. It was more that I wanted to give the hint for later patches.

Thanks much and hope that helps, Jonathan