ag/rebase-i-rewrite-todo, was Re: What's cooking in git.git (Jun 2018, #07; Thu, 28)

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jul 3, 2018, 12:52 UTC
Message-ID: <nycvar.QRO.7.76.6.1807031438240.75@tvgsbejvaqbjf.bet>
In-Reply-To: <xmqqd0wawpwy.fsf@gitster-ct.c.googlers.com>

Hi Junio,

On Thu, 28 Jun 2018, Junio C Hamano wrote:

Show 7 quoted lines

> * ag/rebase-i-rewrite-todo (2018-06-15) 3 commits
>  - rebase--interactive: rewrite the edit-todo functionality in C
>  - editor: add a function to launch the sequence editor
>  - Merge branch 'bc/t3430-fixup' into ag/rebase-i-rewrite-todo
>  (this branch uses ag/rebase-i-append-todo-help.)
> 
>  Stepwise rewriting of the machinery of "rebase -i" into C continues.

Alban abided by your wish and smooshed those patch series into one honking big one, to grow even further with his ongoing work. I have to admit that I am not enthusiastic about this, as it will make it even harder to squeeze in the time for me to review those patches.

The latest iteration of this is here: https://public-inbox.org/git/20180702105717.26386-5-alban.gruin@gmail.com/T/#r8eea71077745d6f2c839acb6200bb8b2bea579d3

I would *strongly* encourage you to allow Alban to go back to the small, incremental patch series he sent before, because it will make it *substantially* easier to not only review, but also develop, and for you to merge.

In this case, for example, the two patches in https://public-inbox.org/git/20180702105717.26386-4-alban.gruin@gmail.com/ and https://public-inbox.org/git/20180702105717.26386-5-alban.gruin@gmail.com/ are ready to go into `next`, like, right now.

Yet because they are now embedded in a larger patch series, they will have to be re-rolled over and over again until *all* of `git-rebase--interactive.sh` is rewritten in C? That's really wasteful of reviewers' time.

Ciao, Dscho