as/sequencer-customizable-comment-char, was Re: What's cooking in git.git (Jun 2018, #07; Thu, 28)

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jul 3, 2018, 11:54 UTC
Message-ID: <nycvar.QRO.7.76.6.1807031353520.75@tvgsbejvaqbjf.bet>
In-Reply-To: <xmqqd0wawpwy.fsf@gitster-ct.c.googlers.com>

Hi Junio & Aaron,

On Thu, 28 Jun 2018, Junio C Hamano wrote:

Show 5 quoted lines

> * as/sequencer-customizable-comment-char (2018-06-28) 1 commit
>  - sequencer: use configured comment character
> 
>  Honor core.commentchar when preparing the list of commits to replay
>  in "rebase -i".

As per https://public-inbox.org/git/nycvar.QRO.7.76.6.1806291607501.74@tvgsbejvaqbjf.bet/ I am inclined to ask for a "v2" (i.e. second iteration of the patch, see e.g. https://github.com/git-for-windows/git/blob/master/CONTRIBUTING.md#submit-the-patch where it talks about submitting an "nth version") that adds an explanation to the commit message why the "auto" value is handled correctly by this patch, as this is not really obvious from reading the diff alone.

After that change, I think this is ready for `next`.

Ciao, Dscho