ag/rebase-i-append-todo-help, was Re: What's cooking in git.git (Jun 2018, #07; Thu, 28)

From: Alban Gruin <alban.gruin@gmail.com>
Date: Jun 29, 2018, 11:10 UTC
Message-ID: <56fc2859-6fb9-62c5-f327-26efae0f38fe@gmail.com>
In-Reply-To: <xmqqd0wawpwy.fsf@gitster-ct.c.googlers.com>

Hi Junio,

Le 28/06/2018 à 23:40, Junio C Hamano a écrit :

Show 11 quoted lines

> * ag/rebase-i-append-todo-help (2018-06-14) 2 commits
>  - rebase--interactive: rewrite append_todo_help() in C
>  - Merge branch 'ag/rebase-p' into ag/rebase-i-append-todo-help
>  (this branch is used by ag/rebase-i-rewrite-todo.)
> 
>  Stepwise rewriting of the machinery of "rebase -i" into C continues.
> 
>  Needs a reroll.
>  cf. <nycvar.QRO.7.76.6.1806261125330.21419@tvgsbejvaqbjf.bet>
> 
>

As I moved append_todo_help() to `rebase-interactive.c`, it should be because I did not changed `msg = _(…)` to `msg = N_(…)`.

It was pointed out on IRC that it was not necessary, after all[0]. Basically, N_() is needed for static variables, not for "dynamic" variables like `msg` in append_todo_help().

[0] http://colabti.org/irclogger/irclogger_log/git-devel?date=2018-06-26#l44

Cheers, Alban