Re: What's cooking in git.git (Jun 2018, #07; Thu, 28)

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Jul 3, 2018, 18:33 UTC
Message-ID: <CAPig+cQkfFv2+FscnVj3gdLAgeQL8k+vCykES6ZVz-8Uq-nFqA@mail.gmail.com>
In-Reply-To: <CABPp-BE=2nzEG=X0Jv3++J3Yo3H0yfJ9vd4pDYYBw5fpzDYc_g@mail.gmail.com>

On Tue, Jul 3, 2018 at 2:31 PM Elijah Newren <newren@gmail.com> wrote:

Show 13 quoted lines

> On Thu, Jun 28, 2018 at 2:40 PM, Junio C Hamano <gitster@pobox.com> wrote:
> > * ds/multi-pack-index (2018-06-25) 24 commits
>
> pu fails to build for me (with the standard 'make DEVELOPER=1 ...'),
> and it appears to come from this series:
>
> midx.c:567:15: error: ‘write_midx_pack_lookup’ defined but not used
> [-Werror=unused-function]
>  static size_t write_midx_pack_lookup(struct hashfile *f,
>
> It looks like the use of this function was removed in v2 of your
> series, but the function itself was left behind?  Could you take a
> look?

Also reported here [1].

[1]: https://public-inbox.org/git/CAPig+cRWwTAFRJOwQOi4USk5UZke=2sz_JVDh3+XRKCcBGD5ow@mail.gmail.com/