Re: [PATCH v5 09/11] technical/shallow: stop referring to grafts
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Apr 26, 2018, 09:19 UTC
- Message-ID
- <nycvar.QRO.7.76.6.1804261117480.4978@tvgsbejvaqbjf.bet>
- In-Reply-To
- <CANQwDwfJgoXd+iH207S8WoaWOS4BQnrm+GAOtfe1BvW9uyKiYA@mail.gmail.com>
Hi Kuba,
On Wed, 25 Apr 2018, Jakub Narębski wrote:
Show 32 quoted lines
> On 25 April 2018 at 11:54, Johannes Schindelin > <johannes.schindelin@gmx.de> wrote: > > diff --git a/Documentation/technical/shallow.txt b/Documentation/technical/shallow.txt > > index 5183b154229..4ec721335d2 100644 > > --- a/Documentation/technical/shallow.txt > > +++ b/Documentation/technical/shallow.txt > > @@ -8,15 +8,10 @@ repo, and therefore grafts are introduced pretending that > > these commits have no parents. > > ********************************************************* > > > > -The basic idea is to write the SHA-1s of shallow commits into > > -$GIT_DIR/shallow, and handle its contents like the contents > > -of $GIT_DIR/info/grafts (with the difference that shallow > > -cannot contain parent information). > > - > > -This information is stored in a new file instead of grafts, or > > -even the config, since the user should not touch that file > > -at all (even throughout development of the shallow clone, it > > -was never manually edited!). > > +$GIT_DIR/shallow lists commit object names and tells Git to > > +pretend as if they are root commits (e.g. "git log" traversal > > +stops after showing them; "git fsck" does not complain saying > > +the commits listed on their "parent" lines do not exist). > > > > Each line contains exactly one SHA-1. When read, a commit_graft > > will be constructed, which has nr_parent < 0 to make it easier > > Is the removed information (repeated below) important or not? > > the user should not touch that file > at all (even throughout development of the shallow clone, it > was never manually edited!).
Back in the days, it might have been necessary to tell people not to meddle with Git's internals. Nowadays I don't think that'd be necessary anymore, hence I removed it.
Ciao, Dscho