git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4 00/11] Deprecate .git/info/grafts

From
Stefan Beller <sbeller@google.com>
Date
Apr 23, 2018, 19:24 UTC
Message-ID
<CAGZ79kaEdb0bd0C7GZXozq2n=CTuB2PZwM6qvgggkdHdNCg=_A@mail.gmail.com>
In-Reply-To
<cover.1524303776.git.johannes.schindelin@gmx.de>

On Sat, Apr 21, 2018 at 2:43 AM, Johannes Schindelin <johannes.schindelin@gmx.de> wrote:

Show 8 quoted lines
> It is fragile, as there is no way for the revision machinery to say "but
> now I want to traverse the graph ignoring the graft file" e.g. when
> pushing commits to a remote repository (which, as a consequence, can
> miss commits).
>
> And we already have a better solution with `git replace --graft <comit>
> [<parent>...]`.
>

Apart from some technical questions on patch 4 [1] this series looks good to me,.

Thanks, Stefan

[1] https://public-inbox.org/git/CAGZ79ka=BLGCCTOw848m0SE9O+ZKhQfiW9RUz99W4=Gdg+7ofQ@mail.gmail.com/
Previous: Johannes SchindelinNext: Johannes Schindelin
Message 66 of 115 in “Deprecate support for .git/info/grafts”
  1. Deprecate support for .git/info/graftsJohannes Schindelin, Apr 13, 2018
  2. Stefan BellerApr 13, 2018
  3. Johannes SchindelinApr 13, 2018
  4. Stefan BellerApr 13, 2018
  5. Johannes SchindelinApr 19, 2018
  6. Eric SunshineApr 13, 2018
  7. Johannes SchindelinApr 19, 2018
  8. 0/7 Deprecate .git/info/graftsJohannes Schindelin, Apr 19, 2018
  9. 1/7 replace: "libify" create_graft()Johannes Schindelin, Apr 19, 2018
  10. Junio C HamanoApr 20, 2018
  11. Jakub NarebskiApr 20, 2018
  12. Johannes SchindelinApr 20, 2018
  13. 2/7 replace: introduce --convert-graft-fileJohannes Schindelin, Apr 19, 2018
  14. Christian CouderApr 19, 2018
  15. Johannes SchindelinApr 20, 2018
  16. Junio C HamanoApr 20, 2018
  17. Johannes SchindelinApr 20, 2018
  18. 3/7 Add a test for `git replace --convert-graft-file`Johannes Schindelin, Apr 19, 2018
  19. Junio C HamanoApr 20, 2018
  20. Johannes SchindelinApr 20, 2018
  21. 4/7 Deprecate support for .git/info/graftsJohannes Schindelin, Apr 19, 2018
  22. 5/7 filter-branch: stop suggesting to use graftsJohannes Schindelin, Apr 19, 2018
  23. 6/7 technical/shallow: describe the relationship with replace refsJohannes Schindelin, Apr 19, 2018
  24. 7/7 technical/shallow: describe why shallow cannot use replace refsJohannes Schindelin, Apr 19, 2018
  25. 00/11 Deprecate .git/info/graftsJohannes Schindelin, Apr 20, 2018
  26. 01/11 argv_array: offer to split a string by whitespaceJohannes Schindelin, Apr 20, 2018
  27. Stefan BellerApr 20, 2018
  28. Johannes SchindelinApr 21, 2018
  29. 02/11 commit: Let the callback of for_each_mergetag return on errorJohannes Schindelin, Apr 20, 2018
  30. 03/11 replace: avoid using die() to indicate a bugJohannes Schindelin, Apr 20, 2018
  31. 04/11 replace: "libify" create_graft() and calleesJohannes Schindelin, Apr 20, 2018
  32. 05/11 replace: introduce --convert-graft-fileJohannes Schindelin, Apr 20, 2018
  33. 06/11 Add a test for `git replace --convert-graft-file`Johannes Schindelin, Apr 20, 2018
  34. SZEDER GáborApr 21, 2018
  35. Johannes SchindelinApr 21, 2018
  36. 07/11 Deprecate support for .git/info/graftsJohannes Schindelin, Apr 20, 2018
  37. 08/11 filter-branch: stop suggesting to use graftsJohannes Schindelin, Apr 20, 2018
  38. 09/11 technical/shallow: describe the relationship with replace refsJohannes Schindelin, Apr 20, 2018
  39. Philip OakleyApr 22, 2018
  40. Johannes SchindelinApr 24, 2018
  41. Philip OakleyApr 24, 2018
  42. Junio C HamanoApr 25, 2018
  43. Johannes SchindelinApr 25, 2018
  44. 10/11 technical/shallow: describe why shallow cannot use replace refsJohannes Schindelin, Apr 20, 2018
  45. 11/11 Remove obsolete script to convert grafts to replace refsJohannes Schindelin, Apr 20, 2018
  46. 00/11 Deprecate .git/info/graftsJohannes Schindelin, Apr 21, 2018
  47. 01/11 argv_array: offer to split a string by whitespaceJohannes Schindelin, Apr 21, 2018
  48. Junio C HamanoApr 24, 2018
  49. Junio C HamanoApr 24, 2018
  50. 02/11 commit: Let the callback of for_each_mergetag return on errorJohannes Schindelin, Apr 21, 2018
  51. 03/11 replace: avoid using die() to indicate a bugJohannes Schindelin, Apr 21, 2018
  52. 04/11 replace: "libify" create_graft() and calleesJohannes Schindelin, Apr 21, 2018
  53. Stefan BellerApr 23, 2018
  54. Johannes SchindelinApr 24, 2018
  55. Stefan BellerApr 24, 2018
  56. Johannes SchindelinApr 25, 2018
  57. 05/11 replace: introduce --convert-graft-fileJohannes Schindelin, Apr 21, 2018
  58. Eric SunshineApr 22, 2018
  59. Johannes SchindelinApr 24, 2018
  60. 06/11 Add a test for `git replace --convert-graft-file`Johannes Schindelin, Apr 21, 2018
  61. 07/11 Deprecate support for .git/info/graftsJohannes Schindelin, Apr 21, 2018
  62. 08/11 filter-branch: stop suggesting to use graftsJohannes Schindelin, Apr 21, 2018
  63. 09/11 technical/shallow: describe the relationship with replace refsJohannes Schindelin, Apr 21, 2018
  64. 10/11 technical/shallow: describe why shallow cannot use replace refsJohannes Schindelin, Apr 21, 2018
  65. 11/11 Remove obsolete script to convert grafts to replace refsJohannes Schindelin, Apr 21, 2018
  66. Stefan BellerApr 23, 2018
  67. 00/11 Deprecate .git/info/graftsJohannes Schindelin, Apr 25, 2018
  68. 01/11 argv_array: offer to split a string by whitespaceJohannes Schindelin, Apr 25, 2018
  69. 03/11 replace: avoid using die() to indicate a bugJohannes Schindelin, Apr 25, 2018
  70. 05/11 replace: introduce --convert-graft-fileJohannes Schindelin, Apr 25, 2018
  71. 02/11 commit: Let the callback of for_each_mergetag return on errorJohannes Schindelin, Apr 25, 2018
  72. 04/11 replace: "libify" create_graft() and calleesJohannes Schindelin, Apr 25, 2018
  73. 07/11 Deprecate support for .git/info/graftsJohannes Schindelin, Apr 25, 2018
  74. 06/11 Add a test for `git replace --convert-graft-file`Johannes Schindelin, Apr 25, 2018
  75. 08/11 filter-branch: stop suggesting to use graftsJohannes Schindelin, Apr 25, 2018
  76. 09/11 technical/shallow: stop referring to graftsJohannes Schindelin, Apr 25, 2018
  77. Jakub NarębskiApr 25, 2018
  78. Johannes SchindelinApr 26, 2018
  79. 11/11 Remove obsolete script to convert grafts to replace refsJohannes Schindelin, Apr 25, 2018
  80. 10/11 technical/shallow: describe why shallow cannot use replace refsJohannes Schindelin, Apr 25, 2018
  81. Junio C HamanoApr 26, 2018
  82. Johannes SchindelinApr 27, 2018
  83. 00/11 Deprecate .git/info/graftsJohannes Schindelin, Apr 27, 2018
  84. 01/11 argv_array: offer to split a string by whitespaceJohannes Schindelin, Apr 27, 2018
  85. 02/11 commit: Let the callback of for_each_mergetag return on errorJohannes Schindelin, Apr 27, 2018
  86. 03/11 replace: avoid using die() to indicate a bugJohannes Schindelin, Apr 27, 2018
  87. 04/11 replace: "libify" create_graft() and calleesJohannes Schindelin, Apr 27, 2018
  88. 05/11 replace: introduce --convert-graft-fileJohannes Schindelin, Apr 27, 2018
  89. 06/11 Add a test for `git replace --convert-graft-file`Johannes Schindelin, Apr 27, 2018
  90. SZEDER GáborApr 28, 2018
  91. Johannes SchindelinApr 28, 2018
  92. 07/11 Deprecate support for .git/info/graftsJohannes Schindelin, Apr 27, 2018
  93. 08/11 filter-branch: stop suggesting to use graftsJohannes Schindelin, Apr 27, 2018
  94. 09/11 technical/shallow: stop referring to graftsJohannes Schindelin, Apr 27, 2018
  95. 10/11 technical/shallow: describe why shallow cannot use replace refsJohannes Schindelin, Apr 27, 2018
  96. 11/11 Remove obsolete script to convert grafts to replace refsJohannes Schindelin, Apr 27, 2018
  97. Philip OakleyApr 28, 2018
  98. Johannes SchindelinApr 28, 2018
  99. Stefan BellerApr 28, 2018
  100. 00/12 Deprecate .git/info/graftsJohannes Schindelin, Apr 28, 2018
  101. 01/12 argv_array: offer to split a string by whitespaceJohannes Schindelin, Apr 28, 2018
  102. 02/12 commit: Let the callback of for_each_mergetag return on errorJohannes Schindelin, Apr 28, 2018
  103. 03/12 replace: avoid using die() to indicate a bugJohannes Schindelin, Apr 28, 2018
  104. 04/12 replace: "libify" create_graft() and calleesJohannes Schindelin, Apr 28, 2018
  105. 05/12 replace: prepare create_graft() for converting graft files wholesaleJohannes Schindelin, Apr 28, 2018
  106. 06/12 replace: introduce --convert-graft-fileJohannes Schindelin, Apr 28, 2018
  107. 07/12 Add a test for `git replace --convert-graft-file`Johannes Schindelin, Apr 28, 2018
  108. 08/12 Deprecate support for .git/info/graftsJohannes Schindelin, Apr 28, 2018
  109. advice: don't pointlessly suggest --convert-graft-fileÆvar Arnfjörð Bjarmason, Nov 27, 2018
  110. Junio C HamanoNov 28, 2018
  111. Johannes SchindelinNov 28, 2018
  112. 09/12 filter-branch: stop suggesting to use graftsJohannes Schindelin, Apr 28, 2018
  113. 10/12 technical/shallow: stop referring to graftsJohannes Schindelin, Apr 28, 2018
  114. 11/12 technical/shallow: describe why shallow cannot use replace refsJohannes Schindelin, Apr 28, 2018
  115. 12/12 Remove obsolete script to convert grafts to replace refsJohannes Schindelin, Apr 28, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.