Re: [PATCH v6 11/11] Remove obsolete script to convert grafts to replace refs

From: Stefan Beller <sbeller@google.com>
Date: Apr 28, 2018, 15:00 UTC
Message-ID: <CAGZ79kb3+TvdHhPkb-PuZFX1RzUq3O2NNVZqa3r5BmOmOXaHdw@mail.gmail.com>
In-Reply-To: <A37AE6B64CF7414ABE41697663B2BEC4@PhilipOakley>

Hi Philip,

On Sat, Apr 28, 2018 at 2:04 AM, Philip Oakley <philipoakley@iee.org> wrote:

Show 8 quoted lines

> From: "Johannes Schindelin" <johannes.schindelin@gmx.de>
>>
>> The functionality is now implemented as `git replace
>> --convert-graft-file`.
>
>
> A rather late in the day thought: Should this go through the same
> deprecation dance?

I think contrib/ has other rules than the core (c.f. `git log --oneline --no-merges --grep "contrib: remove"`) which is why I'd consider the deprecation dance unneeded.

> At least it will catch those who arrive via random web advice!

Good point, unlike the other removals, this is not a dormant project.

I would still think it is ok to remove it. Those who are looking for this script, surely will look at the man page of git-replace or are looking for the grafts. `man gitglossary` is already sufficient:

grafts
           Grafts enables [...]

           Note that the grafts mechanism is outdated and can
           lead to problems transferring objects between
           repositories; see git-replace(1) for a more flexible
           and robust system to do the same thing.