Re: [PATCH] Deprecate support for .git/info/grafts

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Apr 13, 2018, 18:57 UTC
Message-ID: <CAPig+cREYENM7Y8SqtG2ket9+oJ6w0OU1_Qa8f-+O_yDyH=Aww@mail.gmail.com>
In-Reply-To: <0f0942043678fe76f8d654306482ee26fac643f0.1523617836.git.johannes.schindelin@gmx.de>

On Fri, Apr 13, 2018 at 7:11 AM, Johannes Schindelin <johannes.schindelin@gmx.de> wrote:

Show 16 quoted lines

> The grafts feature was a convenient way to "stich together" ancient
> history to the fresh start of linux.git.
> [...]
> The much younger feature implemented as `git replace` set out to remedy
> those limitations and dangerous bugs.
>
> Seeing as `git replace` is pretty mature by now, it is time to deprecate
> support for the graft file, and to retire it eventually.
>
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> ---
>  advice.c                  | 2 ++
>  advice.h                  | 1 +
>  commit.c                  | 9 +++++++++
>  t/t6001-rev-list-graft.sh | 9 +++++++++
>  4 files changed, 21 insertions(+)

Perhaps, as part of this deprecation, the example in Documentation/git-filter-branch.txt should be updated to suggest git-replace instead of .git/info/grafts.

Maybe, also, Documentation/shallow.txt should talk about replace-refs rather than .git/info/grafts.