Re: [STGIT PATCH] replace "git repo-config" usage by "git config"

From: Jakub Narebski <jnareb@gmail.com>
Date: Jan 16, 2008, 21:13 UTC
Message-ID: <m3y7aplbie.fsf@roke.D-201>
In-Reply-To: <200801162158.26450.kumbayo84@arcor.de>

Peter Oberndorfer <kumbayo84@arcor.de> writes:

Show 7 quoted lines

> "git repo-config" will be removed soon
> 
> Signed-off-by: Peter Oberndorfer <kumbayo84@arcor.de>
> ---
> since i am not good at creating log messages, feel free to change it :-)
> built on top of kha experimental patch
> passes all testcases for me

Show 9 quoted lines

> @@ -47,7 +47,7 @@ class GitConfig:
>          if self.__cache.has_key(name):
>              return self.__cache[name]
>          try:
> -            value = Run('git', 'repo-config', '--get', name).output_one_line()
> +            value = Run('git', 'config', '--get', name).output_one_line()
>          except RunException:
>              value = self.__defaults.get(name, None)
>          self.__cache[name] = value

Strange that StGIT didn't abstracted out reading git config, like Git.pm and gitweb.perl did.

BTW. will StGIT be using libgit-thin + PyGit, or is it not ready yet?

-- 
Jakub Narebski
Poland
ShadeHawk on #git