Re: [STGIT PATCH] replace "git repo-config" usage by "git config"

From: Peter Oberndorfer <kumbayo84@arcor.de>
Date: Jan 16, 2008, 21:46 UTC
Message-ID: <200801162246.21854.kumbayo84@arcor.de>
In-Reply-To: <m3y7aplbie.fsf@roke.D-201>

On Mittwoch 16 Januar 2008, Jakub Narebski wrote:

Show 15 quoted lines

> Peter Oberndorfer <kumbayo84@arcor.de> writes:
> 
> > "git repo-config" will be removed soon
> > 
> > Signed-off-by: Peter Oberndorfer <kumbayo84@arcor.de>
> > ---
> > since i am not good at creating log messages, feel free to change it :-)
> > built on top of kha experimental patch
> > passes all testcases for me
> 
> > @@ -47,7 +47,7 @@ class GitConfig:
> >          if self.__cache.has_key(name):
> >              return self.__cache[name]
> >          try:
> > -            value = Run('git', 'repo-config', '--get',

name).output_one_line()

Show 8 quoted lines

> > +            value = Run('git', 'config', '--get', name).output_one_line()
> >          except RunException:
> >              value = self.__defaults.get(name, None)
> >          self.__cache[name] = value
> 
> Strange that StGIT didn't abstracted out reading git config, like
> Git.pm and gitweb.perl did.
>

It is abstracted, that is why the patch only affectes stgit/config.py :-) (beside tests) Or do you mean another type of abstraction like loading the whole config file at once?

> BTW. will StGIT be using libgit-thin + PyGit, or is it not ready yet?
>

I did not hear about it lately. But since i do not create stgit patches very often i have to say actually i actually have no idea.

Greetings Peter