Re: [STGIT PATCH] replace "git repo-config" usage by "git config"

From: Karl Hasselström <kha@treskal.com>
Date: Jan 23, 2008, 16:10 UTC
Message-ID: <20080123161014.GA5850@diana.vm.bytemark.co.uk>
In-Reply-To: <b0943d9e0801230335m4a2d1855uf465d0d134f3ef39@mail.gmail.com>

On 2008-01-23 11:35:03 +0000, Catalin Marinas wrote:

Show 8 quoted lines

> On 18/01/2008, Karl Hasselström <kha@treskal.com> wrote:
>
> > The following changes since commit
> > 5b2666bab799830ac5e511f35103d04fc3968b32:
>
> I merged your patches but I have some wishes. Could we keep pretty
> much the same reporting messages? For example, pushing reports a
> conflict but it no longer lists which files conflicted.

Mmm, that's a regression. Will try to see where that got lost.

> The 'goto' checks the local status before pushing but doesn't report
> this (and my machine is slow and it might wait even 20 seconds or
> more, it is useful to get some messages).

No, it doesn't anymore, so it should be faster than before. Instead of checking the entire tree for cleanliness, it just relies on git-read-tree -u -m to abort without changes if any of the files that need updating are dirty.

This goes for all commands using the new infrastructure, by the way. They share a _lot_ of code.

> The pop/push commands report that the action took place. The one
> with "action ... done" was friendlier I think, especially with the
> 'pop' command reporting that it popped the patches but it waits
> quite a lot before returning.

Yes, I agree that the current output is not optimal.

-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle