git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [STGIT PATCH] replace "git repo-config" usage by "git config"

From
CMCatalin Marinas <catalin.marinas@gmail.com>
Date
Jan 17, 2008, 17:07 UTC
Message-ID
<b0943d9e0801170907x9c4721cy4e5ac886eb61e0a5@mail.gmail.com>
In-Reply-To
<m3y7aplbie.fsf@roke.D-201>
Hi,
Now I'm back from holiday and I'll start merging patches. Thanks for the fixes.
On 16/01/2008, Jakub Narebski <jnareb@gmail.com> wrote:
> Strange that StGIT didn't abstracted out reading git config, like
> Git.pm and gitweb.perl did.

The initial implementation was to use Python to parse the config file but it was dropped in favour of the git-config tool. It might be a bit slower but, at least, we don't need to follow any future syntax changes.

> BTW. will StGIT be using libgit-thin + PyGit, or is it not ready yet?

The last commit to the libgit project seems to be in August 2007. Is it still maintained? If GIT will provide a stable API and library, we might use it but I don't think it would bring a great performance improvement. Most of the time, in my case, seems to be spent in calls list git-diff-tree. A few tens of milliseconds avoided by not calling an external tool would be unnoticed.

-- 
Catalin
Previous: Peter OberndorferNext: Jakub Narebski
Message 11 of 21 in “Remove repo-config”
  1. Remove repo-configDan McGee, Jan 16, 2008
  2. Junio C HamanoJan 16, 2008
  3. Dan McGeeJan 16, 2008
  4. Junio C HamanoJan 16, 2008
  5. Junio C HamanoJan 16, 2008
  6. Junio C HamanoJan 16, 2008
  7. Peter OberndorferJan 16, 2008
  8. replace "git repo-config" usage by "git config"Peter Oberndorfer, Jan 16, 2008
  9. Jakub NarebskiJan 16, 2008
  10. Peter OberndorferJan 16, 2008
  11. Catalin MarinasJan 17, 2008
  12. Jakub NarebskiJan 17, 2008
  13. Karl HasselströmJan 17, 2008
  14. Karl HasselströmJan 18, 2008
  15. Catalin MarinasJan 23, 2008
  16. Karl HasselströmJan 23, 2008
  17. Catalin MarinasJan 23, 2008
  18. Karl HasselströmJan 24, 2008
  19. Catalin MarinasJan 24, 2008
  20. Karl HasselströmJan 24, 2008
  21. Catalin MarinasJan 24, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.