Re: [PATCH] git-grep: add --color to highlight matches

From: Jakub Narebski <jnareb@gmail.com>
Date: May 24, 2008, 08:28 UTC
Message-ID: <m3ve142jkc.fsf@localhost.localdomain>
In-Reply-To: <20080524043118.GA23118@laptop>

Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:

> +--color::
> +	Show colored matches.
> +

Why not borrow from GNU grep manpage?

   --colour[=WHEN], --color[=WHEN]
      Surround  the  matching  string  with  the marker find in GREP_COLOR
      environment variable. WHEN may be 'never', 'always', or 'auto'

We probably would also want it configurable (via config variables), as `color.grep' I guess.

I think compatibility with grep (using GREP_COLOR) would be good idea, and easily implemented.

-- 
Jakub Narebski
Poland
ShadeHawk on #git