Re: [PATCH] git-grep: add --color to highlight matches

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: May 26, 2008, 10:16 UTC
Message-ID: <alpine.DEB.1.00.0805261113050.30431@racer>
In-Reply-To: <483A7B1F.1050608@op5.se>

Hi,

On Mon, 26 May 2008, Andreas Ericsson wrote:

Show 5 quoted lines

> I can't help but think that colorization for external-grep systems only 
> would still be worthwhile, as the majority of git users are on such 
> systems. It'd still be a separate implementation from adding it to the 
> internal grep functionality anyways, so it's not as if work would be 
> lost by going half the way here.

Huh? I thought that the external grep is only a matter of fallback for performance reasons (if the files are already checked out), or if the user specifies the external grep explicitely.

At least for the platform we bend over most, our beloved anachronistic M$ Windows, I do not recall forcing external grep.

Besides, it would be a kludge at best to work _twice_ to find out the search terms, once in the external grep, and a second time in the coloring code. So I think it should not be done.

Ciao, Dscho