Re: [PATCH] git-grep: add --color to highlight matches

From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date: May 24, 2008, 09:20 UTC
Message-ID: <fcaeb9bf0805240220x78943f8ap67344a508531faa0@mail.gmail.com>
In-Reply-To: <m3ve142jkc.fsf@localhost.localdomain>

On Sat, May 24, 2008 at 3:28 PM, Jakub Narebski <jnareb@gmail.com> wrote:

Show 14 quoted lines

> Nguyen Thai Ngoc Duy <pclouds@gmail.com> writes:
>
>> +--color::
>> +     Show colored matches.
>> +
>
> Why not borrow from GNU grep manpage?
>
>   --colour[=WHEN], --color[=WHEN]
>      Surround  the  matching  string  with  the marker find in GREP_COLOR
>      environment variable. WHEN may be 'never', 'always', or 'auto'
>
> We probably would also want it configurable (via config variables),
> as `color.grep' I guess.

Yes. But this patch was really to scratch my itch and I felt good after having it colorized so did not bother with configuration system. I will probably make it a config var when I get tired of typing --color too often ;)

> I think compatibility with grep (using GREP_COLOR) would be good idea,
> and easily implemented.

I had no idea that variable existed.

Show 5 quoted lines

> --
> Jakub Narebski
> Poland
> ShadeHawk on #git
>

-- 
Duy