Re: [PATCH] git-grep: add --color to highlight matches

From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date: May 26, 2008, 11:07 UTC
Message-ID: <fcaeb9bf0805260407r6a1bea23v3861d3c43df01939@mail.gmail.com>
In-Reply-To: <alpine.DEB.1.00.0805261200330.30431@racer>

On Mon, May 26, 2008 at 6:00 PM, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:

Show 14 quoted lines

> Hi,
>
> On Mon, 26 May 2008, Nguyen Thai Ngoc Duy wrote:
>
>> On Mon, May 26, 2008 at 5:16 PM, Johannes Schindelin
>> <Johannes.Schindelin@gmx.de> wrote:
>> > Besides, it would be a kludge at best to work _twice_ to find out the
>> > search terms, once in the external grep, and a second time in the coloring
>> > code.  So I think it should not be done.
>>
>> I think if it's GNU grep, just passing it --color, it will grep and
>> colorize search terms in one turn.
>
> And what tells you that the called grep is GNU grep?

A newly added macro like HAS_GNU_GREP? Granted it won't work all the time. The user who set the macro should know what he is doing. This approach is IMHO fine as long as we don't allow color customization.

-- 
Duy