Re: [PATCHv3 2/3] cvsimport: fix the parsing of uppercase config options

From: Jakub Narebski <jnareb@gmail.com>
Date: Dec 1, 2010, 16:23 UTC
Message-ID: <m3aakp4g5o.fsf@localhost.localdomain>
In-Reply-To: <20101201160503.GB26120@burratino>

Jonathan Nieder <jrnieder@gmail.com> writes:

Show 32 quoted lines

> Martin Langhoff wrote:
> 
> > So cvsimport.remote (for -r) and cvsimport.revisions (or
> > trackrevisions perhaps) seem more appropriate.
> 
> I somewhat like this idea.  So let's build a full table, shall
> we?  The embedded dashes are meant for the command-line options
> rather than the config file.
> 
> 	-v	verbosity
> 	-d	cvsroot
> 	-C	[doesn't make sense in a config file; you've already
> 		 found where to read the configuration from, right?]
> 	-r	remote
> 	-o	mainline
> 	-i	import-only
> 	-k	kill-keywords
> 	-u	replace-underscores
> 	-s	replace-slashes
> 	-p	cvsps-options
> 	-z	fuzz
> 	-P	[doesn't make much sense in a config file; for one-shot use]
> 	-m	detect-merges
> 	-M	merge-regex
> 	-S	ignore-paths
> 	-a	import-all
> 	-L	max-commits
> 	-A	authors-file
> 	-R	track-revisions
> 	-h	[doesn't make sense in a config file]
> 
> Hmm?

Good idea, though I'd rather we avoid new convention for multi word names separated with '-' (multi-word), but rather use camel case (multiWord).

Currently we have only unfortunate exception of `add.ignore-errors', all others use either same case (`core.ignorecase') or camelCase (`core.ignoreStat`).

-- 
Jakub Narebski
Poland
ShadeHawk on #git