Re: [PATCH 2/3] cvsimport: fix the parsing of uppercase config options

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 27, 2010, 06:38 UTC
Message-ID: <7vwrnznueh.fsf@alter.siamese.dyndns.org>
In-Reply-To: <ad36bc3f6a00c5f7bc643be3f97aa2bcfda990ff.1290697830.git.git@drmicha.warpmail.net>

Michael J Gruber <git@drmicha.warpmail.net> writes:

Show 14 quoted lines

> The current code leads to
>
> fatal: bad config value for 'cvsimport.r' in .git/config
>
> for a standard use case with cvsimport.r set:
>
> cvsimport sets internal variables by checking the config for each
> possible command line option. The problem is that config items are case
> insensitive, so config.r and config.R are the same. The ugly error is
> due to that fact that cvsimport expects a bool for -R (and thus
> config.R) but a remote name for -r (and thus config.r).
>
> Fix this by making cvsimport expect the config item "cvsimport.RR"
> for the command line option "-R" etc.

I do not think this is "fixing" per-se. Isn't it more like "We didn't have a way to use the configuration file to specify uppercase option; now we do thanks to this patch, and here is how"?

And the "here is how" workaround, while it may be a reasonable way out, is so obscure that it needs to be documented, no? Ahh, that is what [3/3] is.

The $ckey change from 1/3 needs to be done here, I think.