Re: [PATCHv3 2/3] cvsimport: fix the parsing of uppercase config options

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 1, 2010, 19:47 UTC
Message-ID: <7vvd3duvfy.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20101201175815.GB7774@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> If there are short config options that work, though, we should probably
> keep them. It surely can't be that hard for the perl code to accept both
> "cvsimport.r" and "cvsimport.remote" for "-r" and
> "cvsimport.generaterevisions" (or whatever) for "-R"?

I'd agree.  The current parameter set we give to GetOptions is:

    haivmkuo:d:p:r:C:z:s:M:P:A:S:L:R

and I notice that we cannot sanely access A, M, P, R, S and their lowercase counterparts.

It shouldn't be too hard to interpret the single letter options for the currently supported set but only for lowercase letters plus '-C <arg>' and '-L <arg>' (because there are no lowercase ones that crash with them), and give long config names to at least the ones inaccessible with the above.

Wouldn't that give us a regression-free solution to the immediate problem at hand?

Supporting long options on the command line, and giving long config name synonyms to the lowercase ones, would be a plus for consistency's sake, but that probably is a separate topic.