Re: [PATCHv3 2/3] cvsimport: fix the parsing of uppercase config options
- From
Martin Langhoff <martin.langhoff@gmail.com>
- Date
- Dec 1, 2010, 14:59 UTC
- Message-ID
- <AANLkTi=cb0i28oGi9vrYfEyU_fPHhQGhNNtramtCpCHy@mail.gmail.com>
- In-Reply-To
- <b61288036e756c78709438491416d573459a732e.1291207768.git.git@drmicha.warpmail.net>
On Wed, Dec 1, 2010 at 7:53 AM, Michael J Gruber <git@drmicha.warpmail.net> wrote:
> Fix this by making cvsimport expect the config item "cvsimport.capital-r" > for the command line option "-R" etc.
Good point to fix this, thanks. But 'capital-r' will muddy the waters further. When accepting configuration from git-config, make all these values the full expanded name.
So cvsimport.remote (for -r) and cvsimport.revisions (or trackrevisions perhaps) seem more appropriate.
cheers,
m
-- martin.langhoff@gmail.com martin@laptop.org -- School Server Architect - ask interesting questions - don't get distracted with shiny stuff - working code first - http://wiki.laptop.org/go/User:Martinlanghoff