Re: [PATCH] git-web--browse: invoke kfmclient directly
- From
Jakub Narebski <jnareb@gmail.com>
- Date
- Sep 19, 2011, 21:32 UTC
- Message-ID
- <m38vpkrzhq.fsf@localhost.localdomain>
- In-Reply-To
- <7vvcso9zzi.fsf@alter.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> writes:
Show 16 quoted lines
> Jeff King <peff@peff.net> writes: > > > If you want to make a test, I think you would do better with something > > like: > > > > echo someurl_with_&_in_it >expect && > > git config browser.custom.cmd echo && > > git web--browse --browser=custom someurl_with_&_in_it >actual && > > test_cmp expect actual > > > > That won't test that we are invoking kfmclient correctly, obviously, but > > you can confirm at least that URLs are making it through to the browser > > script intact. > > Hmm, isn't '&' somewhat an unusual in URL? ...ah, not really, if it is in > the query parameter part it is quite common.
In newstyle URLs the name=value pairs in CGI parameter query string are separated with semicolons ';' rather than ampersands '&', because of problem with & <-> &.
Just FYI.
-- Jakub Narębski